Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp

Issue 2804383002: Replace ASSERT with DCHECK in modules/accessibility (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp b/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
index 67dd659bbf883fc1a8c32f3fd03ab68365429083..4014fdb61fd944fa946abf79ce58aeace0ae0dd3 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
@@ -39,7 +39,7 @@ AXMenuListOption::AXMenuListOption(HTMLOptionElement* element,
: AXMockObject(axObjectCache), m_element(element) {}
AXMenuListOption::~AXMenuListOption() {
- ASSERT(!m_element);
+ DCHECK(!m_element);
}
void AXMenuListOption::detach() {
@@ -117,12 +117,12 @@ void AXMenuListOption::getRelativeBounds(
AXObject* parent = parentObject();
if (!parent)
return;
- ASSERT(parent->isMenuListPopup());
+ DCHECK(parent->isMenuListPopup());
AXObject* grandparent = parent->parentObject();
if (!grandparent)
return;
- ASSERT(grandparent->isMenuList());
+ DCHECK(grandparent->isMenuList());
grandparent->getRelativeBounds(outContainer, outBoundsInContainer,
outContainerTransform);
}
@@ -136,7 +136,7 @@ String AXMenuListOption::textAlternative(bool recursive,
// If nameSources is non-null, relatedObjects is used in filling it in, so it
// must be non-null as well.
if (nameSources)
- ASSERT(relatedObjects);
+ DCHECK(relatedObjects);
if (!getNode())
return String();

Powered by Google App Engine
This is Rietveld 408576698