Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2801603003: Add SpdyString alias for std::string in net/spdy. (Closed)

Created:
3 years, 8 months ago by diannahu
Modified:
3 years, 8 months ago
Reviewers:
Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, fuzzing_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add SpdyString alias for std::string in net/spdy. Since string is called string in Google3 but std::string in Chromium, an alias is needed to make the two codebases identical. Also ran git cl format. This CL lands server change 151592591 by bnc. BUG=488484 Review-Url: https://codereview.chromium.org/2801603003 Cr-Commit-Position: refs/heads/master@{#462728} Committed: https://chromium.googlesource.com/chromium/src/+/401e364c7ce7bf260c825537c7f549b5d5fc6039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+785 lines, -806 lines) Patch
M net/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M net/spdy/array_output_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl_unittest.cc View 6 chunks +5 lines, -5 lines 0 comments Download
M net/spdy/buffered_spdy_framer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/fuzzing/hpack_example_generator.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M net/spdy/fuzzing/hpack_fuzz_util.h View 5 chunks +6 lines, -6 lines 0 comments Download
M net/spdy/fuzzing/hpack_fuzz_util.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M net/spdy/fuzzing/hpack_fuzz_util_test.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M net/spdy/header_coalescer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/spdy/header_coalescer_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/spdy/hpack/hpack_decoder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/hpack/hpack_decoder.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/spdy/hpack/hpack_decoder3_test.cc View 26 chunks +30 lines, -30 lines 0 comments Download
M net/spdy/hpack/hpack_decoder_test.cc View 21 chunks +22 lines, -26 lines 0 comments Download
M net/spdy/hpack/hpack_encoder.h View 5 chunks +5 lines, -5 lines 0 comments Download
M net/spdy/hpack/hpack_encoder.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M net/spdy/hpack/hpack_encoder_test.cc View 8 chunks +8 lines, -10 lines 0 comments Download
M net/spdy/hpack/hpack_entry.h View 3 chunks +4 lines, -5 lines 0 comments Download
M net/spdy/hpack/hpack_entry.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/spdy/hpack/hpack_entry_test.cc View 2 chunks +1 line, -5 lines 0 comments Download
M net/spdy/hpack/hpack_header_table_test.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M net/spdy/hpack/hpack_huffman_decoder.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/spdy/hpack/hpack_huffman_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/hpack/hpack_huffman_decoder_test.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M net/spdy/hpack/hpack_huffman_table.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/spdy/hpack/hpack_huffman_table.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/spdy/hpack/hpack_huffman_table_test.cc View 14 chunks +34 lines, -32 lines 0 comments Download
M net/spdy/hpack/hpack_input_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/hpack/hpack_input_stream.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/spdy/hpack/hpack_input_stream_test.cc View 11 chunks +28 lines, -30 lines 0 comments Download
M net/spdy/hpack/hpack_output_stream.h View 3 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/hpack/hpack_output_stream.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M net/spdy/hpack/hpack_output_stream_test.cc View 9 chunks +25 lines, -27 lines 0 comments Download
M net/spdy/hpack/hpack_round_trip_test.cc View 8 chunks +8 lines, -10 lines 0 comments Download
M net/spdy/http2_frame_decoder_adapter.cc View 4 chunks +3 lines, -5 lines 0 comments Download
A net/spdy/platform/api/spdy_string.h View 1 chunk +16 lines, -0 lines 0 comments Download
M net/spdy/platform/api/spdy_string_utils.h View 1 chunk +4 lines, -4 lines 0 comments Download
M net/spdy/platform/api/spdy_string_utils_test.cc View 5 chunks +6 lines, -6 lines 0 comments Download
A net/spdy/platform/impl/spdy_string_impl.h View 1 chunk +16 lines, -0 lines 0 comments Download
M net/spdy/platform/impl/spdy_string_utils_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format.h View 5 chunks +9 lines, -9 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format.cc View 8 chunks +10 lines, -11 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format_test.cc View 14 chunks +15 lines, -15 lines 0 comments Download
M net/spdy/spdy_buffer_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M net/spdy/spdy_deframer_visitor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_deframer_visitor.cc View 8 chunks +6 lines, -8 lines 0 comments Download
M net/spdy/spdy_deframer_visitor_test.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M net/spdy/spdy_frame_builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_framer.h View 4 chunks +6 lines, -6 lines 0 comments Download
M net/spdy/spdy_framer.cc View 22 chunks +21 lines, -23 lines 0 comments Download
M net/spdy/spdy_framer_decoder_adapter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_framer_test.cc View 18 chunks +18 lines, -20 lines 0 comments Download
M net/spdy/spdy_header_block.h View 4 chunks +5 lines, -5 lines 0 comments Download
M net/spdy/spdy_header_block.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M net/spdy/spdy_header_block_test.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M net/spdy/spdy_header_indexing.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_header_indexing.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_header_indexing_test.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M net/spdy/spdy_http_stream.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 6 chunks +9 lines, -10 lines 0 comments Download
M net/spdy/spdy_http_utils.cc View 6 chunks +10 lines, -11 lines 0 comments Download
M net/spdy/spdy_log_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/spdy_log_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/spdy/spdy_log_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 57 chunks +74 lines, -77 lines 0 comments Download
M net/spdy/spdy_pinnable_buffer_piece_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/spdy/spdy_prefixed_buffer_reader_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/spdy/spdy_protocol.h View 10 chunks +12 lines, -12 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/spdy_protocol_test.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket.h View 4 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M net/spdy/spdy_read_queue_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M net/spdy/spdy_session.h View 10 chunks +10 lines, -10 lines 0 comments Download
M net/spdy/spdy_session.cc View 14 chunks +16 lines, -16 lines 0 comments Download
M net/spdy/spdy_session_pool.h View 4 chunks +5 lines, -6 lines 0 comments Download
M net/spdy/spdy_session_pool.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M net/spdy/spdy_session_pool_unittest.cc View 17 chunks +22 lines, -23 lines 0 comments Download
M net/spdy/spdy_session_test_util.h View 3 chunks +5 lines, -6 lines 0 comments Download
M net/spdy/spdy_session_test_util.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 19 chunks +30 lines, -31 lines 0 comments Download
M net/spdy/spdy_stream.h View 4 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_stream.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M net/spdy/spdy_stream_test_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_stream_test_util.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 15 chunks +14 lines, -15 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 4 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 10 chunks +18 lines, -18 lines 0 comments Download
M net/spdy/spdy_test_utils.h View 2 chunks +13 lines, -13 lines 0 comments Download
M net/spdy/spdy_test_utils.cc View 5 chunks +15 lines, -17 lines 0 comments Download
M net/spdy/spdy_write_queue_unittest.cc View 10 chunks +14 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
diannahu
\o/
3 years, 8 months ago (2017-04-06 15:43:08 UTC) #6
Bence
LGTM. Thank you!
3 years, 8 months ago (2017-04-06 22:04:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801603003/1
3 years, 8 months ago (2017-04-06 22:05:53 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 01:18:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/401e364c7ce7bf260c825537c7f5...

Powered by Google App Engine
This is Rietveld 408576698