Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 2799913003: Fix some net/spdy lint picks, from git cl lint. (Closed)

Created:
3 years, 8 months ago by diannahu
Modified:
3 years, 8 months ago
Reviewers:
Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, fuzzing_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some net/spdy lint picks, from git cl lint. These lint picks were noticed in the merge https://codereview.chromium.org/2801603003/. I am putting the lint picks into a separate issue because the original issue is big enough as is. BUG=488484 Review-Url: https://codereview.chromium.org/2799913003 Cr-Commit-Position: refs/heads/master@{#462870} Committed: https://chromium.googlesource.com/chromium/src/+/a14ac14be5af16d7cac7393497b0bea4d9e19032

Patch Set 1 #

Patch Set 2 : Set upstream branch to Issue 2801603003 as trybots pass. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M net/spdy/header_coalescer_test.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M net/spdy/hpack/hpack_output_stream.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/platform/impl/spdy_string_utils_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_header_block.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_http_utils.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M net/spdy/spdy_proxy_client_socket.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_read_queue_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_stream_test_util.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_stream_test_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_test_utils.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M net/spdy/spdy_write_queue_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
diannahu
Piggybacking some minor lint picks diffbased from http://crrev.com/2801603003. Thanks!
3 years, 8 months ago (2017-04-06 20:05:58 UTC) #6
Bence
LGTM. Thank you so much, this is really great!
3 years, 8 months ago (2017-04-06 22:01:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799913003/20001
3 years, 8 months ago (2017-04-07 14:39:18 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 15:45:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a14ac14be5af16d7cac7393497b0...

Powered by Google App Engine
This is Rietveld 408576698