Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: net/spdy/hpack/hpack_decoder.cc

Issue 2801603003: Add SpdyString alias for std::string in net/spdy. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/spdy/hpack/hpack_decoder.h ('k') | net/spdy/hpack/hpack_decoder3_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/hpack/hpack_decoder.h" 5 #include "net/spdy/hpack/hpack_decoder.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "net/spdy/hpack/hpack_constants.h" 10 #include "net/spdy/hpack/hpack_constants.h"
11 #include "net/spdy/hpack/hpack_entry.h" 11 #include "net/spdy/hpack/hpack_entry.h"
12 #include "net/spdy/platform/api/spdy_estimate_memory_usage.h" 12 #include "net/spdy/platform/api/spdy_estimate_memory_usage.h"
13 #include "net/spdy/spdy_flags.h" 13 #include "net/spdy/spdy_flags.h"
14 14
15 namespace net { 15 namespace net {
16 16
17 using std::string;
18
19 HpackDecoder::HpackDecoder() 17 HpackDecoder::HpackDecoder()
20 : handler_(nullptr), 18 : handler_(nullptr),
21 total_header_bytes_(0), 19 total_header_bytes_(0),
22 total_parsed_bytes_(0), 20 total_parsed_bytes_(0),
23 header_block_started_(false), 21 header_block_started_(false),
24 size_updates_seen_(0), 22 size_updates_seen_(0),
25 size_updates_allowed_(true), 23 size_updates_allowed_(true),
26 incremental_decode_(false) {} 24 incremental_decode_(false) {}
27 25
28 HpackDecoder::~HpackDecoder() {} 26 HpackDecoder::~HpackDecoder() {}
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 key_buffer_.assign(entry->name().data(), entry->name().size()); 262 key_buffer_.assign(entry->name().data(), entry->name().size());
265 *next_name = key_buffer_; 263 *next_name = key_buffer_;
266 } 264 }
267 return true; 265 return true;
268 } 266 }
269 267
270 bool HpackDecoder::DecodeNextStringLiteral(HpackInputStream* input_stream, 268 bool HpackDecoder::DecodeNextStringLiteral(HpackInputStream* input_stream,
271 bool is_key, 269 bool is_key,
272 SpdyStringPiece* output) { 270 SpdyStringPiece* output) {
273 if (input_stream->MatchPrefixAndConsume(kStringLiteralHuffmanEncoded)) { 271 if (input_stream->MatchPrefixAndConsume(kStringLiteralHuffmanEncoded)) {
274 string* buffer = is_key ? &key_buffer_ : &value_buffer_; 272 SpdyString* buffer = is_key ? &key_buffer_ : &value_buffer_;
275 bool result = input_stream->DecodeNextHuffmanString(buffer); 273 bool result = input_stream->DecodeNextHuffmanString(buffer);
276 *output = SpdyStringPiece(*buffer); 274 *output = SpdyStringPiece(*buffer);
277 return result; 275 return result;
278 } else if (input_stream->MatchPrefixAndConsume( 276 } else if (input_stream->MatchPrefixAndConsume(
279 kStringLiteralIdentityEncoded)) { 277 kStringLiteralIdentityEncoded)) {
280 return input_stream->DecodeNextIdentityString(output); 278 return input_stream->DecodeNextIdentityString(output);
281 } else { 279 } else {
282 DVLOG(1) << "String literal is neither Huffman nor identity encoded!"; 280 DVLOG(1) << "String literal is neither Huffman nor identity encoded!";
283 return false; 281 return false;
284 } 282 }
285 } 283 }
286 284
287 } // namespace net 285 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/hpack/hpack_decoder.h ('k') | net/spdy/hpack/hpack_decoder3_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698