Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: net/spdy/spdy_proxy_client_socket_unittest.cc

Issue 2801603003: Add SpdyString alias for std::string in net/spdy. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_proxy_client_socket.cc ('k') | net/spdy/spdy_read_queue_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_proxy_client_socket_unittest.cc
diff --git a/net/spdy/spdy_proxy_client_socket_unittest.cc b/net/spdy/spdy_proxy_client_socket_unittest.cc
index 5ab6550e06f83fa5d6e2c04264a3cdb95d86f46f..e32e435b4c1c9c026ea4efe161d7090bfb0e5a5d 100644
--- a/net/spdy/spdy_proxy_client_socket_unittest.cc
+++ b/net/spdy/spdy_proxy_client_socket_unittest.cc
@@ -122,7 +122,7 @@ class SpdyProxyClientSocketTest : public PlatformTest {
base::RunLoop().RunUntilIdle();
}
- void CloseSpdySession(Error error, const std::string& description) {
+ void CloseSpdySession(Error error, const SpdyString& description) {
spdy_session_->CloseSessionOnError(error, description);
}
@@ -139,7 +139,7 @@ class SpdyProxyClientSocketTest : public PlatformTest {
SpdySessionDependencies session_deps_;
MockConnect connect_data_;
base::WeakPtr<SpdySession> spdy_session_;
- std::string user_agent_;
+ SpdyString user_agent_;
GURL url_;
HostPortPair proxy_host_port_;
HostPortPair endpoint_host_port_pair_;
@@ -242,7 +242,7 @@ void SpdyProxyClientSocketTest::AssertSyncReadEquals(const char* data,
int len) {
scoped_refptr<IOBuffer> buf(new IOBuffer(len));
ASSERT_EQ(len, sock_->Read(buf.get(), len, CompletionCallback()));
- ASSERT_EQ(std::string(data, len), std::string(buf->data(), len));
+ ASSERT_EQ(SpdyString(data, len), SpdyString(buf->data(), len));
ASSERT_TRUE(sock_->IsConnected());
}
@@ -258,7 +258,7 @@ void SpdyProxyClientSocketTest::AssertAsyncReadEquals(const char* data,
EXPECT_EQ(len, read_callback_.WaitForResult());
EXPECT_TRUE(sock_->IsConnected());
- ASSERT_EQ(std::string(data, len), std::string(buf->data(), len));
+ ASSERT_EQ(SpdyString(data, len), SpdyString(buf->data(), len));
}
void SpdyProxyClientSocketTest::AssertReadStarts(const char* data, int len) {
@@ -274,7 +274,7 @@ void SpdyProxyClientSocketTest::AssertReadReturns(const char* data, int len) {
// Now the read will return
EXPECT_EQ(len, read_callback_.WaitForResult());
- ASSERT_EQ(std::string(data, len), std::string(read_buf_->data(), len));
+ ASSERT_EQ(SpdyString(data, len), SpdyString(read_buf_->data(), len));
}
void SpdyProxyClientSocketTest::AssertAsyncWriteSucceeds(const char* data,
@@ -454,7 +454,7 @@ TEST_F(SpdyProxyClientSocketTest, ConnectRedirects) {
ASSERT_FALSE(headers->HasHeader("set-cookie"));
ASSERT_TRUE(headers->HasHeaderValue("content-length", "0"));
- std::string location;
+ SpdyString location;
ASSERT_TRUE(headers->IsRedirect(&location));
ASSERT_EQ(location, kRedirectUrl);
@@ -568,7 +568,7 @@ TEST_F(SpdyProxyClientSocketTest, WriteSendsDataInDataFrame) {
}
TEST_F(SpdyProxyClientSocketTest, WriteSplitsLargeDataIntoMultipleFrames) {
- std::string chunk_data(kMaxSpdyFrameChunkSize, 'x');
+ SpdyString chunk_data(kMaxSpdyFrameChunkSize, 'x');
SpdySerializedFrame conn(ConstructConnectRequestFrame());
SpdySerializedFrame chunk(
ConstructBodyFrame(chunk_data.data(), chunk_data.length()));
@@ -586,7 +586,7 @@ TEST_F(SpdyProxyClientSocketTest, WriteSplitsLargeDataIntoMultipleFrames) {
AssertConnectSucceeds();
- std::string big_data(kMaxSpdyFrameChunkSize * 3, 'x');
+ SpdyString big_data(kMaxSpdyFrameChunkSize * 3, 'x');
scoped_refptr<IOBufferWithSize> buf(CreateBuffer(big_data.data(),
big_data.length()));
@@ -796,7 +796,7 @@ TEST_F(SpdyProxyClientSocketTest, MultipleReadsFromSameLargeFrame) {
// Now attempt to do a read of more data than remains buffered
scoped_refptr<IOBuffer> buf(new IOBuffer(kLen33));
ASSERT_EQ(kLen3, sock_->Read(buf.get(), kLen33, read_callback_.callback()));
- ASSERT_EQ(std::string(kMsg3, kLen3), std::string(buf->data(), kLen3));
+ ASSERT_EQ(SpdyString(kMsg3, kLen3), SpdyString(buf->data(), kLen3));
ASSERT_TRUE(sock_->IsConnected());
}
@@ -1025,7 +1025,7 @@ TEST_F(SpdyProxyClientSocketTest, ReadOnClosedSocketReturnsBufferedData) {
ASSERT_FALSE(sock_->IsConnected());
scoped_refptr<IOBuffer> buf(new IOBuffer(kLen1));
ASSERT_EQ(kLen1, sock_->Read(buf.get(), kLen1, CompletionCallback()));
- ASSERT_EQ(std::string(kMsg1, kLen1), std::string(buf->data(), kLen1));
+ ASSERT_EQ(SpdyString(kMsg1, kLen1), SpdyString(buf->data(), kLen1));
ASSERT_EQ(0, sock_->Read(NULL, 1, CompletionCallback()));
ASSERT_EQ(0, sock_->Read(NULL, 1, CompletionCallback()));
@@ -1114,7 +1114,7 @@ TEST_F(SpdyProxyClientSocketTest, WritePendingOnClose) {
// Make sure the write actually starts.
base::RunLoop().RunUntilIdle();
- CloseSpdySession(ERR_ABORTED, std::string());
+ CloseSpdySession(ERR_ABORTED, SpdyString());
EXPECT_THAT(write_callback_.WaitForResult(), IsError(ERR_CONNECTION_CLOSED));
}
« no previous file with comments | « net/spdy/spdy_proxy_client_socket.cc ('k') | net/spdy/spdy_read_queue_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698