Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1463)

Unified Diff: net/spdy/spdy_stream_unittest.cc

Issue 2801603003: Add SpdyString alias for std::string in net/spdy. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_stream_test_util.cc ('k') | net/spdy/spdy_test_util_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_stream_unittest.cc
diff --git a/net/spdy/spdy_stream_unittest.cc b/net/spdy/spdy_stream_unittest.cc
index f8400dda1c608173352c1c00b7694a1c61e557fc..50b2a1bd65d3948947d2d1400c7f5dd38358d915 100644
--- a/net/spdy/spdy_stream_unittest.cc
+++ b/net/spdy/spdy_stream_unittest.cc
@@ -10,7 +10,6 @@
#include <cstddef>
#include <limits>
#include <memory>
-#include <string>
#include <utility>
#include <vector>
@@ -196,7 +195,7 @@ TEST_F(SpdyStreamTest, SendDataAfterOpen) {
EXPECT_TRUE(delegate.send_headers_completed());
EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy_util_.GetStatusKey()));
- EXPECT_EQ(std::string(kPostBody, kPostBodyLength),
+ EXPECT_EQ(SpdyString(kPostBody, kPostBodyLength),
delegate.TakeReceivedData());
EXPECT_TRUE(data.AllWriteDataConsumed());
}
@@ -277,7 +276,7 @@ TEST_F(SpdyStreamTest, Trailers) {
const SpdyHeaderBlock& received_trailers = delegate.trailers();
SpdyHeaderBlock::const_iterator it = received_trailers.find("foo");
EXPECT_EQ("bar", it->second);
- EXPECT_EQ(std::string(kPostBody, kPostBodyLength),
+ EXPECT_EQ(SpdyString(kPostBody, kPostBodyLength),
delegate.TakeReceivedData());
EXPECT_TRUE(data.AllWriteDataConsumed());
}
@@ -424,7 +423,7 @@ TEST_F(SpdyStreamTest, StreamError) {
EXPECT_TRUE(delegate.send_headers_completed());
EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy_util_.GetStatusKey()));
- EXPECT_EQ(std::string(kPostBody, kPostBodyLength),
+ EXPECT_EQ(SpdyString(kPostBody, kPostBodyLength),
delegate.TakeReceivedData());
EXPECT_TRUE(data.AllWriteDataConsumed());
@@ -449,7 +448,7 @@ TEST_F(SpdyStreamTest, SendLargeDataAfterOpenRequestResponse) {
kDefaultUrl, 1, kPostBodyLength, LOWEST, nullptr, 0));
AddWrite(req);
- std::string chunk_data(kMaxSpdyFrameChunkSize, 'x');
+ SpdyString chunk_data(kMaxSpdyFrameChunkSize, 'x');
SpdySerializedFrame chunk(spdy_util_.ConstructSpdyDataFrame(
1, chunk_data.data(), chunk_data.length(), false));
AddWrite(chunk);
@@ -478,7 +477,7 @@ TEST_F(SpdyStreamTest, SendLargeDataAfterOpenRequestResponse) {
SPDY_REQUEST_RESPONSE_STREAM, session, url_, LOWEST, NetLogWithSource());
ASSERT_TRUE(stream);
- std::string body_data(3 * kMaxSpdyFrameChunkSize, 'x');
+ SpdyString body_data(3 * kMaxSpdyFrameChunkSize, 'x');
StreamDelegateWithBody delegate(stream, body_data);
stream->SetDelegate(&delegate);
@@ -494,7 +493,7 @@ TEST_F(SpdyStreamTest, SendLargeDataAfterOpenRequestResponse) {
EXPECT_TRUE(delegate.send_headers_completed());
EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy_util_.GetStatusKey()));
- EXPECT_EQ(std::string(), delegate.TakeReceivedData());
+ EXPECT_EQ(SpdyString(), delegate.TakeReceivedData());
EXPECT_TRUE(data.AllWriteDataConsumed());
}
@@ -508,7 +507,7 @@ TEST_F(SpdyStreamTest, SendLargeDataAfterOpenBidirectional) {
SpdySerializedFrame resp(spdy_util_.ConstructSpdyPostReply(nullptr, 0));
AddRead(resp);
- std::string chunk_data(kMaxSpdyFrameChunkSize, 'x');
+ SpdyString chunk_data(kMaxSpdyFrameChunkSize, 'x');
SpdySerializedFrame chunk(spdy_util_.ConstructSpdyDataFrame(
1, chunk_data.data(), chunk_data.length(), false));
AddWrite(chunk);
@@ -531,7 +530,7 @@ TEST_F(SpdyStreamTest, SendLargeDataAfterOpenBidirectional) {
SPDY_BIDIRECTIONAL_STREAM, session, url_, LOWEST, NetLogWithSource());
ASSERT_TRUE(stream);
- std::string body_data(3 * kMaxSpdyFrameChunkSize, 'x');
+ SpdyString body_data(3 * kMaxSpdyFrameChunkSize, 'x');
StreamDelegateSendImmediate delegate(stream, body_data);
stream->SetDelegate(&delegate);
@@ -547,7 +546,7 @@ TEST_F(SpdyStreamTest, SendLargeDataAfterOpenBidirectional) {
EXPECT_TRUE(delegate.send_headers_completed());
EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy_util_.GetStatusKey()));
- EXPECT_EQ(std::string(), delegate.TakeReceivedData());
+ EXPECT_EQ(SpdyString(), delegate.TakeReceivedData());
EXPECT_TRUE(data.AllWriteDataConsumed());
}
@@ -787,7 +786,7 @@ TEST_F(SpdyStreamTest, HeadersMustHaveStatusOnPushedStream) {
EXPECT_THAT(delegate.WaitForClose(), IsOk());
EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy_util_.GetStatusKey()));
- EXPECT_EQ(std::string(kPostBody, kPostBodyLength),
+ EXPECT_EQ(SpdyString(kPostBody, kPostBodyLength),
delegate.TakeReceivedData());
// Finish async network reads and writes.
@@ -897,7 +896,7 @@ TEST_F(SpdyStreamTest, HeadersMustPreceedDataOnPushedStream) {
EXPECT_THAT(delegate.WaitForClose(), IsOk());
EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy_util_.GetStatusKey()));
- EXPECT_EQ(std::string(kPostBody, kPostBodyLength),
+ EXPECT_EQ(SpdyString(kPostBody, kPostBodyLength),
delegate.TakeReceivedData());
// Finish async network reads and writes.
@@ -1076,7 +1075,7 @@ TEST_F(SpdyStreamTest, InformationalHeaders) {
EXPECT_THAT(delegate.WaitForClose(), IsOk());
EXPECT_EQ("200", delegate.GetResponseHeaderValue(spdy_util_.GetStatusKey()));
- EXPECT_EQ(std::string(kPostBody, kPostBodyLength),
+ EXPECT_EQ(SpdyString(kPostBody, kPostBodyLength),
delegate.TakeReceivedData());
// Finish async network reads and writes.
@@ -1388,7 +1387,7 @@ void SpdyStreamTest::RunResumeAfterUnstallRequestResponseTest(
EXPECT_TRUE(delegate.send_headers_completed());
EXPECT_EQ("200", delegate.GetResponseHeaderValue(":status"));
- EXPECT_EQ(std::string(), delegate.TakeReceivedData());
+ EXPECT_EQ(SpdyString(), delegate.TakeReceivedData());
EXPECT_TRUE(data.AllWriteDataConsumed());
}
@@ -1469,7 +1468,7 @@ void SpdyStreamTest::RunResumeAfterUnstallBidirectionalTest(
EXPECT_TRUE(delegate.send_headers_completed());
EXPECT_EQ("200", delegate.GetResponseHeaderValue(":status"));
- EXPECT_EQ(std::string(kPostBody, kPostBodyLength),
+ EXPECT_EQ(SpdyString(kPostBody, kPostBodyLength),
delegate.TakeReceivedData());
EXPECT_TRUE(data.AllWriteDataConsumed());
}
« no previous file with comments | « net/spdy/spdy_stream_test_util.cc ('k') | net/spdy/spdy_test_util_common.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698