Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: net/spdy/spdy_read_queue_unittest.cc

Issue 2801603003: Add SpdyString alias for std::string in net/spdy. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/spdy/spdy_proxy_client_socket_unittest.cc ('k') | net/spdy/spdy_session.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/spdy_read_queue.h" 5 #include "net/spdy/spdy_read_queue.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cstddef> 8 #include <cstddef>
9 #include <memory> 9 #include <memory>
10 #include <string>
11 10
12 #include "base/bind.h" 11 #include "base/bind.h"
13 #include "base/memory/ptr_util.h" 12 #include "base/memory/ptr_util.h"
14 #include "base/stl_util.h" 13 #include "base/stl_util.h"
14 #include "net/spdy/platform/api/spdy_string.h"
15 #include "net/spdy/spdy_buffer.h" 15 #include "net/spdy/spdy_buffer.h"
16 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
17 17
18 namespace net { 18 namespace net {
19 namespace test { 19 namespace test {
20 namespace { 20 namespace {
21 21
22 const char kData[] = "SPDY read queue test data.\0Some more data."; 22 const char kData[] = "SPDY read queue test data.\0Some more data.";
23 const size_t kDataSize = arraysize(kData); 23 const size_t kDataSize = arraysize(kData);
24 24
25 // Enqueues |data| onto |queue| in chunks of at most |max_buffer_size| 25 // Enqueues |data| onto |queue| in chunks of at most |max_buffer_size|
26 // bytes. 26 // bytes.
27 void EnqueueString(const std::string& data, 27 void EnqueueString(const SpdyString& data,
28 size_t max_buffer_size, 28 size_t max_buffer_size,
29 SpdyReadQueue* queue) { 29 SpdyReadQueue* queue) {
30 ASSERT_GT(data.size(), 0u); 30 ASSERT_GT(data.size(), 0u);
31 ASSERT_GT(max_buffer_size, 0u); 31 ASSERT_GT(max_buffer_size, 0u);
32 size_t old_total_size = queue->GetTotalSize(); 32 size_t old_total_size = queue->GetTotalSize();
33 for (size_t i = 0; i < data.size();) { 33 for (size_t i = 0; i < data.size();) {
34 size_t buffer_size = std::min(data.size() - i, max_buffer_size); 34 size_t buffer_size = std::min(data.size() - i, max_buffer_size);
35 queue->Enqueue(std::unique_ptr<SpdyBuffer>( 35 queue->Enqueue(std::unique_ptr<SpdyBuffer>(
36 new SpdyBuffer(data.data() + i, buffer_size))); 36 new SpdyBuffer(data.data() + i, buffer_size)));
37 i += buffer_size; 37 i += buffer_size;
38 EXPECT_FALSE(queue->IsEmpty()); 38 EXPECT_FALSE(queue->IsEmpty());
39 EXPECT_EQ(old_total_size + i, queue->GetTotalSize()); 39 EXPECT_EQ(old_total_size + i, queue->GetTotalSize());
40 } 40 }
41 } 41 }
42 42
43 // Dequeues all bytes in |queue| in chunks of at most 43 // Dequeues all bytes in |queue| in chunks of at most
44 // |max_buffer_size| bytes and returns the data as a string. 44 // |max_buffer_size| bytes and returns the data as a string.
45 std::string DrainToString(size_t max_buffer_size, SpdyReadQueue* queue) { 45 SpdyString DrainToString(size_t max_buffer_size, SpdyReadQueue* queue) {
46 std::string data; 46 SpdyString data;
47 47
48 // Pad the buffer so we can detect out-of-bound writes. 48 // Pad the buffer so we can detect out-of-bound writes.
49 size_t padding = std::max(static_cast<size_t>(4096), queue->GetTotalSize()); 49 size_t padding = std::max(static_cast<size_t>(4096), queue->GetTotalSize());
50 size_t buffer_size_with_padding = padding + max_buffer_size + padding; 50 size_t buffer_size_with_padding = padding + max_buffer_size + padding;
51 std::unique_ptr<char[]> buffer(new char[buffer_size_with_padding]); 51 std::unique_ptr<char[]> buffer(new char[buffer_size_with_padding]);
52 std::memset(buffer.get(), 0, buffer_size_with_padding); 52 std::memset(buffer.get(), 0, buffer_size_with_padding);
53 char* buffer_data = buffer.get() + padding; 53 char* buffer_data = buffer.get() + padding;
54 54
55 while (!queue->IsEmpty()) { 55 while (!queue->IsEmpty()) {
56 size_t old_total_size = queue->GetTotalSize(); 56 size_t old_total_size = queue->GetTotalSize();
(...skipping 14 matching lines...) Expand all
71 EXPECT_EQ(queue->GetTotalSize(), old_total_size - dequeued_bytes); 71 EXPECT_EQ(queue->GetTotalSize(), old_total_size - dequeued_bytes);
72 } 72 }
73 EXPECT_TRUE(queue->IsEmpty()); 73 EXPECT_TRUE(queue->IsEmpty());
74 return data; 74 return data;
75 } 75 }
76 76
77 // Enqueue a test string with the given enqueue/dequeue max buffer 77 // Enqueue a test string with the given enqueue/dequeue max buffer
78 // sizes. 78 // sizes.
79 void RunEnqueueDequeueTest(size_t enqueue_max_buffer_size, 79 void RunEnqueueDequeueTest(size_t enqueue_max_buffer_size,
80 size_t dequeue_max_buffer_size) { 80 size_t dequeue_max_buffer_size) {
81 std::string data(kData, kDataSize); 81 SpdyString data(kData, kDataSize);
82 SpdyReadQueue read_queue; 82 SpdyReadQueue read_queue;
83 EnqueueString(data, enqueue_max_buffer_size, &read_queue); 83 EnqueueString(data, enqueue_max_buffer_size, &read_queue);
84 const std::string& drained_data = 84 const SpdyString& drained_data =
85 DrainToString(dequeue_max_buffer_size, &read_queue); 85 DrainToString(dequeue_max_buffer_size, &read_queue);
86 EXPECT_EQ(data, drained_data); 86 EXPECT_EQ(data, drained_data);
87 } 87 }
88 88
89 void OnBufferDiscarded(bool* discarded, 89 void OnBufferDiscarded(bool* discarded,
90 size_t* discarded_bytes, 90 size_t* discarded_bytes,
91 size_t delta, 91 size_t delta,
92 SpdyBuffer::ConsumeSource consume_source) { 92 SpdyBuffer::ConsumeSource consume_source) {
93 EXPECT_EQ(SpdyBuffer::DISCARD, consume_source); 93 EXPECT_EQ(SpdyBuffer::DISCARD, consume_source);
94 *discarded = true; 94 *discarded = true;
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 130
131 read_queue.Clear(); 131 read_queue.Clear();
132 132
133 EXPECT_TRUE(discarded); 133 EXPECT_TRUE(discarded);
134 EXPECT_EQ(kDataSize, discarded_bytes); 134 EXPECT_EQ(kDataSize, discarded_bytes);
135 EXPECT_TRUE(read_queue.IsEmpty()); 135 EXPECT_TRUE(read_queue.IsEmpty());
136 } 136 }
137 137
138 } // namespace test 138 } // namespace test
139 } // namespace net 139 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/spdy_proxy_client_socket_unittest.cc ('k') | net/spdy/spdy_session.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698