Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: net/spdy/buffered_spdy_framer_unittest.cc

Issue 2801603003: Add SpdyString alias for std::string in net/spdy. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/buffered_spdy_framer.h ('k') | net/spdy/fuzzing/hpack_example_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/buffered_spdy_framer_unittest.cc
diff --git a/net/spdy/buffered_spdy_framer_unittest.cc b/net/spdy/buffered_spdy_framer_unittest.cc
index 870ab36620abd255f009b7055d5f49c392aa8267..770f21c4b110fefd9d21233bd8e78ec9e37df150 100644
--- a/net/spdy/buffered_spdy_framer_unittest.cc
+++ b/net/spdy/buffered_spdy_framer_unittest.cc
@@ -34,7 +34,7 @@ class TestBufferedSpdyVisitor : public BufferedSpdyFramerVisitorInterface {
}
void OnStreamError(SpdyStreamId stream_id,
- const std::string& description) override {
+ const SpdyString& description) override {
VLOG(1) << "SpdyFramer Error on stream: " << stream_id << " "
<< description;
error_count_++;
@@ -167,11 +167,11 @@ class TestBufferedSpdyVisitor : public BufferedSpdyFramerVisitorInterface {
// OnGoAway parameters.
SpdyStreamId goaway_last_accepted_stream_id_;
SpdyErrorCode goaway_error_code_;
- std::string goaway_debug_data_;
+ SpdyString goaway_debug_data_;
// OnAltSvc parameters.
SpdyStreamId altsvc_stream_id_;
- std::string altsvc_origin_;
+ SpdyString altsvc_origin_;
SpdyAltSvcWireFormat::AlternativeServiceVector altsvc_vector_;
};
@@ -194,7 +194,7 @@ TEST_F(BufferedSpdyFramerTest, OnSetting) {
TEST_F(BufferedSpdyFramerTest, HeaderListTooLarge) {
SpdyHeaderBlock headers;
- std::string long_header_value(256 * 1024, 'x');
+ SpdyString long_header_value(256 * 1024, 'x');
headers["foo"] = long_header_value;
SpdyHeadersIR headers_ir(/*stream_id=*/1, std::move(headers));
« no previous file with comments | « net/spdy/buffered_spdy_framer.h ('k') | net/spdy/fuzzing/hpack_example_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698