Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: net/spdy/platform/api/spdy_string_utils_test.cc

Issue 2801603003: Add SpdyString alias for std::string in net/spdy. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/platform/api/spdy_string_utils.h ('k') | net/spdy/platform/impl/spdy_string_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/platform/api/spdy_string_utils_test.cc
diff --git a/net/spdy/platform/api/spdy_string_utils_test.cc b/net/spdy/platform/api/spdy_string_utils_test.cc
index e7df3b65d34d64cd4bb9b516eb0854f63ff901d1..20992f998ce9cc3df5e33cebf2908270133881c6 100644
--- a/net/spdy/platform/api/spdy_string_utils_test.cc
+++ b/net/spdy/platform/api/spdy_string_utils_test.cc
@@ -19,7 +19,7 @@ TEST(SpdyStringUtilsTest, SpdyStrCat) {
// Single string-like argument.
const char kFoo[] = "foo";
- const std::string string_foo(kFoo);
+ const SpdyString string_foo(kFoo);
const SpdyStringPiece stringpiece_foo(string_foo);
EXPECT_EQ("foo", SpdyStrCat(kFoo));
EXPECT_EQ("foo", SpdyStrCat(string_foo));
@@ -28,7 +28,7 @@ TEST(SpdyStringUtilsTest, SpdyStrCat) {
// Two string-like arguments.
const char kBar[] = "bar";
const SpdyStringPiece stringpiece_bar(kBar);
- const std::string string_bar(kBar);
+ const SpdyString string_bar(kBar);
EXPECT_EQ("foobar", SpdyStrCat(kFoo, kBar));
EXPECT_EQ("foobar", SpdyStrCat(kFoo, string_bar));
EXPECT_EQ("foobar", SpdyStrCat(kFoo, stringpiece_bar));
@@ -72,13 +72,13 @@ TEST(SpdyStringUtilsTest, SpdyStrCat) {
TEST(SpdyStringUtilsTest, SpdyStrAppend) {
// No arguments on empty string.
- std::string output;
+ SpdyString output;
SpdyStrAppend(&output);
EXPECT_TRUE(output.empty());
// Single string-like argument.
const char kFoo[] = "foo";
- const std::string string_foo(kFoo);
+ const SpdyString string_foo(kFoo);
const SpdyStringPiece stringpiece_foo(string_foo);
SpdyStrAppend(&output, kFoo);
EXPECT_EQ("foo", output);
@@ -96,7 +96,7 @@ TEST(SpdyStringUtilsTest, SpdyStrAppend) {
// Two string-like arguments.
const char kBar[] = "bar";
const SpdyStringPiece stringpiece_bar(kBar);
- const std::string string_bar(kBar);
+ const SpdyString string_bar(kBar);
SpdyStrAppend(&output, kFoo, kBar);
EXPECT_EQ("foobar", output);
SpdyStrAppend(&output, kFoo, string_bar);
@@ -173,7 +173,7 @@ TEST(SpdyStringUtilsTest, SpdyStringPrintf) {
}
TEST(SpdyStringUtilsTest, SpdyStringAppendF) {
- std::string output;
+ SpdyString output;
SpdyStringAppendF(&output, "%s", "");
EXPECT_TRUE(output.empty());
« no previous file with comments | « net/spdy/platform/api/spdy_string_utils.h ('k') | net/spdy/platform/impl/spdy_string_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698