Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2781923003: Add DCHECK to WebSharedWorkerImpl to assert WebFrameClient params. (Closed)

Created:
3 years, 8 months ago by sashab
Modified:
3 years, 8 months ago
Reviewers:
slangley, kinuko, haraken, dcheng
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DCHECK to WebSharedWorkerImpl to assert WebFrameClient params. Since the WebLocalFrame* parameter being passed is already available from WebSharedWorkerImpl, these should always match. This is pre-work to remove the (now redundant) parameter since it's already available from inside the method. BUG=361765 Review-Url: https://codereview.chromium.org/2781923003 Cr-Commit-Position: refs/heads/master@{#460331} Committed: https://chromium.googlesource.com/chromium/src/+/34f3ee879659a25c0903950f59e864afd60ef140

Patch Set 1 #

Messages

Total messages: 15 (6 generated)
sashab
3 years, 8 months ago (2017-03-28 23:25:52 UTC) #2
slangley
lgtm
3 years, 8 months ago (2017-03-29 00:09:44 UTC) #3
sashab
3 years, 8 months ago (2017-03-29 00:10:57 UTC) #5
sashab
-haraken +dcheng
3 years, 8 months ago (2017-03-29 03:27:44 UTC) #7
dcheng
rs lgtm
3 years, 8 months ago (2017-03-29 03:58:53 UTC) #8
kinuko
drive-by lgtm (and hoping we can clean it up in this class soon too!)
3 years, 8 months ago (2017-03-29 04:52:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781923003/1
3 years, 8 months ago (2017-03-29 05:04:41 UTC) #11
haraken
LGTM
3 years, 8 months ago (2017-03-29 06:20:37 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 09:05:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/34f3ee879659a25c0903950f59e8...

Powered by Google App Engine
This is Rietveld 408576698