Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2782063003: Remove redundant WebLocalFrame* parameter from runScriptsAtDocumentReady (Closed)

Created:
3 years, 8 months ago by sashab
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant WebLocalFrame* parameter from runScriptsAtDocumentReady Remove redundant WebLocalFrame* parameter from runScriptsAtDocumentReady in WebFrameClient. BUG=361765 Review-Url: https://codereview.chromium.org/2782063003 Cr-Commit-Position: refs/heads/master@{#461056} Committed: https://chromium.googlesource.com/chromium/src/+/482e2c4294af73b28d60b9c00aae2570e6ae2ca2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (11 generated)
sashab
Thx for these reviews joel! feel free to do them tomorrow though, really no hurry. ...
3 years, 8 months ago (2017-03-29 06:46:19 UTC) #2
joelhockey
lgtm
3 years, 8 months ago (2017-03-29 08:39:49 UTC) #3
sashab
3 years, 8 months ago (2017-03-30 01:38:38 UTC) #5
dcheng
LGTM, but you'll need a //content/renderer owner
3 years, 8 months ago (2017-03-30 04:04:51 UTC) #6
sashab
jochen ptal at content
3 years, 8 months ago (2017-03-30 04:06:29 UTC) #8
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-03-30 11:48:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782063003/1
3 years, 8 months ago (2017-03-31 00:40:32 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/395416)
3 years, 8 months ago (2017-03-31 02:05:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782063003/1
3 years, 8 months ago (2017-03-31 05:57:50 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 06:35:29 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/482e2c4294af73b28d60b9c00aae...

Powered by Google App Engine
This is Rietveld 408576698