Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2781993004: Remove redundant WebLocalFrame* parameter from didCreateNewDocument (Closed)

Created:
3 years, 8 months ago by sashab
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant WebLocalFrame* parameter from didCreateNewDocument Remove redundant WebLocalFrame* parameter from didCreateNewDocument in WebFrameClient. BUG=361765

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -4 lines 2 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2781923003 Patch 1

Messages

Total messages: 15 (5 generated)
sashab
3 years, 8 months ago (2017-03-29 06:20:28 UTC) #2
joelhockey
lgtm
3 years, 8 months ago (2017-03-29 06:44:00 UTC) #3
dglazkov
lgtm
3 years, 8 months ago (2017-03-29 14:59:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2781993004/1
3 years, 8 months ago (2017-03-30 01:38:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/398303)
3 years, 8 months ago (2017-03-30 01:52:04 UTC) #9
sashab
jochen ptal @ content
3 years, 8 months ago (2017-03-30 02:01:50 UTC) #11
jochen (gone - plz use gerrit)
lgtm with comment https://codereview.chromium.org/2781993004/diff/1/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (left): https://codereview.chromium.org/2781993004/diff/1/content/renderer/render_frame_impl.cc#oldcode3784 content/renderer/render_frame_impl.cc:3784: DCHECK(!frame_ || frame_ == frame); maybe ...
3 years, 8 months ago (2017-03-30 11:44:22 UTC) #12
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2781993004/diff/1/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (left): https://codereview.chromium.org/2781993004/diff/1/content/renderer/render_frame_impl.cc#oldcode3784 content/renderer/render_frame_impl.cc:3784: DCHECK(!frame_ || frame_ == frame); on second thought, please ...
3 years, 8 months ago (2017-03-30 11:49:59 UTC) #13
sashab
Frame_ can never be null -- see the only callsite, which dereferences frame_.
3 years, 8 months ago (2017-03-31 00:15:28 UTC) #14
sashab
3 years, 8 months ago (2017-03-31 00:37:23 UTC) #15 
Ignore that comment. Will take a closer look, thanks.

Powered by Google App Engine
This is Rietveld 408576698