Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2785583003: Remove redundant WebLocalFrame* parameter from didCreateDocumentElement (Closed)

Created:
3 years, 8 months ago by sashab
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant WebLocalFrame* parameter from didCreateDocumentElement Remove redundant WebLocalFrame* parameter from didCreateDocumentElement in WebFrameClient. BUG=361765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2781923003 Patch 1

Messages

Total messages: 12 (5 generated)
sashab
3 years, 8 months ago (2017-03-29 06:28:57 UTC) #2
joelhockey
lgtm
3 years, 8 months ago (2017-03-29 06:43:32 UTC) #3
dglazkov
lgtm
3 years, 8 months ago (2017-03-29 14:59:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785583003/1
3 years, 8 months ago (2017-03-30 01:38:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/398302)
3 years, 8 months ago (2017-03-30 01:53:48 UTC) #9
sashab
jochen ptal @ content
3 years, 8 months ago (2017-03-30 02:01:56 UTC) #11
jochen (gone - plz use gerrit)
3 years, 8 months ago (2017-03-30 11:45:10 UTC) #12 
please investigate the redness on the bots

Powered by Google App Engine
This is Rietveld 408576698