Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2786593002: Remove redundant WebLocalFrame* in runScriptsAtDocumentElementAvailable (Closed)

Created:
3 years, 8 months ago by sashab
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant WebLocalFrame* in runScriptsAtDocumentElementAvailable Remove redundant WebLocalFrame* parameter from runScriptsAtDocumentElementAvailable in WebFrameClient. BUG=361765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2781923003 Patch 1

Messages

Total messages: 12 (5 generated)
sashab
3 years, 8 months ago (2017-03-29 06:34:36 UTC) #2
dglazkov
lgtm
3 years, 8 months ago (2017-03-29 14:59:57 UTC) #4
slangley
lgtm
3 years, 8 months ago (2017-03-29 23:20:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786593002/1
3 years, 8 months ago (2017-03-30 01:39:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/398304)
3 years, 8 months ago (2017-03-30 01:53:50 UTC) #9
sashab
jochen ptal @ content
3 years, 8 months ago (2017-03-30 02:02:02 UTC) #11
jochen (gone - plz use gerrit)
3 years, 8 months ago (2017-03-30 11:45:51 UTC) #12 
lgtm

Powered by Google App Engine
This is Rietveld 408576698