Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2782783002: Remove redundant WebLocalFrame* parameter from didFinishDocumentLoad (Closed)

Created:
3 years, 8 months ago by sashab
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, jochen+watch_chromium.org, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, Peter Beverloo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant WebLocalFrame* parameter from didFinishDocumentLoad Remove redundant WebLocalFrame* parameter from didFinishDocumentLoad in WebFrameClient. BUG=361765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -29 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/test_runner/web_frame_test_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/test_runner/web_frame_test_client.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/shell/test_runner/web_frame_test_proxy.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2781923003 Patch 1

Dependent Patchsets:

Issue 2780993003 Patch 1

Messages

Total messages: 13 (6 generated)
sashab
3 years, 8 months ago (2017-03-29 02:57:34 UTC) #3
dglazkov
lgtm
3 years, 8 months ago (2017-03-29 02:59:49 UTC) #5
joelhockey
lgtm
3 years, 8 months ago (2017-03-29 03:10:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782783002/1
3 years, 8 months ago (2017-03-30 01:39:58 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/398295)
3 years, 8 months ago (2017-03-30 01:54:41 UTC) #10
sashab
jochen ptal @ content
3 years, 8 months ago (2017-03-30 02:02:14 UTC) #12
jochen (gone - plz use gerrit)
3 years, 8 months ago (2017-03-30 11:47:07 UTC) #13 
the test failure looks relevant, please address

Powered by Google App Engine
This is Rietveld 408576698