Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 2779893006: Remove WebLocalFrame* from didReceiveServerRedirectForProvisionalLoad (Closed)

Created:
3 years, 8 months ago by sashab
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, jochen+watch_chromium.org, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, Peter Beverloo
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebLocalFrame* from didReceiveServerRedirectForProvisionalLoad Remove redundant WebLocalFrame* parameter from didReceiveServerRedirectForProvisionalLoad in WebFrameClient. BUG=361765 Review-Url: https://codereview.chromium.org/2779893006 Cr-Commit-Position: refs/heads/master@{#461001} Committed: https://chromium.googlesource.com/chromium/src/+/97a6cd07bba4da3053a08fc7d06d35678588e054

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/shell/test_runner/web_frame_test_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/test_runner/web_frame_test_client.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/shell/test_runner/web_frame_test_proxy.h View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
sashab
3 years, 8 months ago (2017-03-30 01:37:31 UTC) #2
slangley
lgtm
3 years, 8 months ago (2017-03-30 02:21:24 UTC) #3
sashab
jochen ptal at content, dglazgov ptal at webkit :)
3 years, 8 months ago (2017-03-30 02:22:05 UTC) #5
dglazkov
lgtm
3 years, 8 months ago (2017-03-30 02:26:05 UTC) #6
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-03-30 11:47:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2779893006/1
3 years, 8 months ago (2017-03-31 02:28:15 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 02:35:22 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/97a6cd07bba4da3053a08fc7d06d...

Powered by Google App Engine
This is Rietveld 408576698