Remove redundant WebLocalFrame* parameter from didCreateDataSource

Remove redundant WebLocalFrame* parameter from didCreateDataSource

Remove redundant WebLocalFrame* parameter from didCreateDataSource
in WebFrameClient.

BUG=361765

[sashab, 2017-03-29 03:18:17]

sashab@chromium.org changed reviewers:
+ joelhockey@chromium.org

[dglazkov, 2017-03-29 03:20:46]

dglazkov@chromium.org changed reviewers:
+ dglazkov@chromium.org

[dglazkov, 2017-03-29 03:20:46]

lgtm

[joelhockey, 2017-03-29 03:22:27]

lgtm

[sashab, 2017-03-30 01:37:22]

The CQ bit was checked by sashab@chromium.org

[sashab, 2017-03-30 01:37:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
joelhockey@chromium.org, dglazkov@chromium.org
Link to the patchset: https://codereview.chromium.org/2780993003/#ps20001
(title: "Rebased onto asserts patch")

[commit-bot: I haz the power, 2017-03-30 01:39:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 01:55:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 01:55:36]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sashab, 2017-03-30 02:01:39]

sashab@chromium.org changed reviewers:
+ jochen@chromium.org

[sashab, 2017-03-30 02:01:40]

jochen ptal @ content

[jochen (gone - plz use gerrit), 2017-03-30 11:43:43]

https://codereview.chromium.org/2780993003/diff/20001/content/renderer/render...
File content/renderer/render_frame_impl.cc (left):

https://codereview.chromium.org/2780993003/diff/20001/content/renderer/render...
content/renderer/render_frame_impl.cc:3389: DCHECK(!frame_ || frame_ == frame);
this doesn't look like it's good enough to proof redundancy (and I think the
crashes you get on the bots are due to this)

[sashab, 2017-03-31 00:35:54]

sashab@chromium.org changed reviewers:
+ dcheng@chromium.org

[sashab, 2017-03-31 00:35:54]

dcheng -- for the DCHECK I've removed, what's the case where |frame_| would be
null, and not equal to |frame|? That sounds like a fix I'd need to submit in a
prior patch.

[sashab, 2017-03-31 00:36:25]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 00:37:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-03-31 01:00:28]

On 2017/03/31 00:35:54, sashab wrote:
> dcheng -- for the DCHECK I've removed, what's the case where |frame_| would be
> null, and not equal to |frame|? That sounds like a fix I'd need to submit in a
> prior patch.

It looks like there's a bit of a chicken-and-egg problem: when bootstrapping
frame creation, we call out to the embedder. But of course, at that point,
content::RenderFrameImpl can't set |frame_| yet because WebLocalFrame is still
being constructed.

[commit-bot: I haz the power, 2017-03-31 01:42:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 01:42:13]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sashab, 2017-05-03 01:06:21]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 01:07:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 01:50:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 01:50:08]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)