Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2771723003: [tracing] Move math utilities from base into their own subdirectory (attempt 2) (Closed)

Created:
3 years, 9 months ago by hjd
Modified:
3 years, 9 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[tracing] Move math utilities from base into their own subdirectory (attempt 2) Reattempting after the last CL missed updating some references to tr.b.Range. Script to rename imports: function names { echo bbox2 echo math echo quad echo rect echo running_statistics echo statistics echo piecewise_linear_function echo range echo range_utils echo sorted_array_utils } function update_exports { local path=$1 sed -i '' "s!tr.exportTo('tr.b'!tr.exportTo('tr.b.math'!g" $path } function from_last_return { local path=$1 local line=$(cat $path | grep return -nr | tail -1 | cut -d: -f2) awk "NR >= $line" $path } function get_exports { local path=$1 from_last_return $path | grep "^ " | sed 's/,//g' | sed 's/ //g' } function update_imports { local path=$1 get_exports $path | while read export; do find tracing dashboard -type f | grep 'html$' | xargs sed -i '' "s!tr.b.$export\([^A-Za-z]\)!tr.b.math.$export\1!g" done } files=$(find tracing dashboard -type f | grep 'html$') gypifiles=$(find tracing dashboard -type f | grep 'gypi$') names | while read name; do sed -i '' "s!tracing/base/$name.html!tracing/base/math/$name.html!g" $files sed -i '' "s!tracing/base/$name.html!tracing/base/math/$name.html!g" $gypifiles update_exports tracing/tracing/base/math/$name.html update_imports tracing/tracing/base/math/$name.html done BUG=catapult:#3425 Review-Url: https://codereview.chromium.org/2771723003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/15150d5bc8db2bb3567c25553725a43bb20edd29

Patch Set 1 #

Patch Set 2 : fix range #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+917 lines, -5240 lines) Patch
M trace_processor/experimental/mappers/scheduling/map_input_blockers.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M trace_processor/experimental/mappers/scheduling/map_wake_ups.html View 1 1 chunk +1 line, -1 line 0 comments Download
M trace_processor/experimental/mappers/slice_cost.html View 1 1 chunk +1 line, -1 line 0 comments Download
M trace_processor/experimental/mappers/trace_stats.html View 1 4 chunks +8 lines, -8 lines 0 comments Download
M trace_processor/experimental/mappers/v8_map_function.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tracing/trace_viewer.gypi View 2 chunks +10 lines, -10 lines 0 comments Download
M tracing/tracing/base/assert_utils.html View 1 chunk +1 line, -1 line 0 comments Download
D tracing/tracing/base/bbox2.html View 1 chunk +0 lines, -156 lines 0 comments Download
D tracing/tracing/base/bbox2_test.html View 1 chunk +0 lines, -36 lines 0 comments Download
D tracing/tracing/base/math.html View 1 chunk +0 lines, -248 lines 0 comments Download
A + tracing/tracing/base/math/bbox2.html View 3 chunks +4 lines, -4 lines 0 comments Download
A + tracing/tracing/base/math/bbox2_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
A + tracing/tracing/base/math/math.html View 2 chunks +2 lines, -2 lines 0 comments Download
A tracing/tracing/base/math/math_test.html View 1 chunk +150 lines, -0 lines 0 comments Download
A + tracing/tracing/base/math/piecewise_linear_function.html View 1 chunk +1 line, -1 line 0 comments Download
A + tracing/tracing/base/math/piecewise_linear_function_test.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + tracing/tracing/base/math/quad.html View 2 chunks +3 lines, -3 lines 0 comments Download
A + tracing/tracing/base/math/quad_test.html View 6 chunks +33 lines, -33 lines 0 comments Download
A + tracing/tracing/base/math/range.html View 4 chunks +9 lines, -9 lines 0 comments Download
A + tracing/tracing/base/math/range_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + tracing/tracing/base/math/range_utils.html View 4 chunks +5 lines, -5 lines 0 comments Download
A + tracing/tracing/base/math/range_utils_test.html View 10 chunks +11 lines, -11 lines 0 comments Download
A + tracing/tracing/base/math/rect.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + tracing/tracing/base/math/rect_test.html View 2 chunks +4 lines, -4 lines 0 comments Download
A + tracing/tracing/base/math/running_statistics.html View 1 chunk +1 line, -1 line 0 comments Download
A + tracing/tracing/base/math/running_statistics_test.html View 1 chunk +4 lines, -4 lines 0 comments Download
A + tracing/tracing/base/math/sorted_array_utils.html View 1 chunk +1 line, -1 line 0 comments Download
A + tracing/tracing/base/math/statistics.html View 8 chunks +9 lines, -9 lines 0 comments Download
A + tracing/tracing/base/math/statistics_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
D tracing/tracing/base/math_test.html View 1 chunk +0 lines, -149 lines 0 comments Download
D tracing/tracing/base/piecewise_linear_function.html View 1 chunk +0 lines, -143 lines 0 comments Download
D tracing/tracing/base/piecewise_linear_function_test.html View 1 chunk +0 lines, -34 lines 0 comments Download
D tracing/tracing/base/quad.html View 1 chunk +0 lines, -235 lines 0 comments Download
D tracing/tracing/base/quad_test.html View 1 chunk +0 lines, -130 lines 0 comments Download
D tracing/tracing/base/range.html View 1 chunk +0 lines, -294 lines 0 comments Download
D tracing/tracing/base/range_test.html View 1 chunk +0 lines, -465 lines 0 comments Download
D tracing/tracing/base/range_utils.html View 1 chunk +0 lines, -140 lines 0 comments Download
D tracing/tracing/base/range_utils_test.html View 1 chunk +0 lines, -133 lines 0 comments Download
D tracing/tracing/base/rect.html View 1 chunk +0 lines, -162 lines 0 comments Download
D tracing/tracing/base/rect_test.html View 1 chunk +0 lines, -31 lines 0 comments Download
D tracing/tracing/base/running_statistics.html View 1 chunk +0 lines, -180 lines 0 comments Download
D tracing/tracing/base/running_statistics_test.html View 1 chunk +0 lines, -193 lines 0 comments Download
M tracing/tracing/base/sinebow_color_generator.html View 2 chunks +4 lines, -4 lines 0 comments Download
D tracing/tracing/base/sorted_array_utils.html View 1 chunk +0 lines, -331 lines 0 comments Download
M tracing/tracing/base/sorted_array_utils_test.html View 6 chunks +7 lines, -7 lines 0 comments Download
D tracing/tracing/base/statistics.html View 1 chunk +0 lines, -848 lines 0 comments Download
D tracing/tracing/base/statistics_test.html View 1 chunk +0 lines, -577 lines 0 comments Download
M tracing/tracing/base/unittest/test_case.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/base/unittest/test_suite.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/android/android_auditor.html View 4 chunks +8 lines, -6 lines 0 comments Download
M tracing/tracing/extras/chrome/cc/layer_impl.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/extras/chrome/cc/layer_tree_host_impl.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/extras/chrome/cc/picture.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/chrome/cc/region.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/extras/chrome/cc/render_pass.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/chrome/cc/tile.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/chrome/cc/util.html View 2 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/extras/chrome/cc/util_test.html View 5 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/extras/chrome/chrome_auditor.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/chrome/estimated_input_latency.html View 7 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/extras/chrome/estimated_input_latency_test.html View 6 chunks +13 lines, -13 lines 0 comments Download
M tracing/tracing/extras/chrome/layout_object.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/extras/cpu/cpu_usage_auditor.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/extras/importer/android/event_log_importer.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/extras/importer/trace_code_map.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/extras/importer/trace_event_importer.html View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/importer/find_input_expectations.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/importer/proto_expectation.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/importer/user_model_builder.html View 3 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/metrics/blink/gc_metric.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/compare_samples_cmdline.html View 3 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/metrics/sample_metric.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/spa_navigation_metric.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/system_health/cpu_time_metric.html View 1 chunk +2 lines, -1 line 0 comments Download
M tracing/tracing/metrics/system_health/cpu_time_metric_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/system_health/expected_queueing_time_metric.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/system_health/loading_metric.html View 3 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/metrics/system_health/long_tasks_metric.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/system_health/memory_metric.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/metrics/system_health/memory_metric_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/system_health/power_metric.html View 10 chunks +13 lines, -12 lines 0 comments Download
M tracing/tracing/metrics/system_health/responsiveness_metric.html View 2 chunks +3 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/system_health/utils.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/metrics/v8/execution_metric.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/v8/gc_metric.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/v8/runtime_stats_metric.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/metrics/v8/utils.html View 3 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/metrics/webrtc/webrtc_rendering_metric.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/metrics/webrtc/webrtc_rendering_metric_test.html View 11 chunks +17 lines, -15 lines 0 comments Download
M tracing/tracing/model/async_slice_group.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/counter.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/counter_sample.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/cpu.html View 5 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/model/cpu_slice.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/cpu_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/device.html View 1 chunk +2 lines, -1 line 0 comments Download
M tracing/tracing/model/event.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/event_container.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/event_set.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/model/frame.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/helpers/android_app.html View 5 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/model/helpers/android_model_helper.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/helpers/android_surface_flinger.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/helpers/chrome_browser_helper_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/helpers/chrome_model_helper.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/helpers/chrome_process_helper.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/helpers/chrome_renderer_helper.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/model.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/model/object_collection.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/object_instance.html View 3 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/model/power_sample_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/power_series.html View 4 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/model/process_base.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/resource_usage_sample_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/model/resource_usage_series.html View 4 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/model/slice_group.html View 5 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/model/thread.html View 5 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/model/thread_test.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/model/thread_time_slice.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/model/time_to_object_instance_map.html View 3 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/model/user_model/user_expectation.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/analysis/generic_object_view.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_allocator_details_pane.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/analysis/multi_event_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_event_summary.html View 7 chunks +9 lines, -9 lines 0 comments Download
M tracing/tracing/ui/analysis/multi_event_summary_table.html View 7 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/ui/analysis/multi_object_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_sample_sub_view.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/analysis/related_events.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/analysis/selection_summary_table.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_thread_time_slice_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/bar_chart_test.html View 4 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/ui/base/camera.html View 8 chunks +12 lines, -11 lines 0 comments Download
M tracing/tracing/ui/base/camera_test.html View 3 chunks +12 lines, -12 lines 0 comments Download
M tracing/tracing/ui/base/chart_base_2d.html View 5 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/ui/base/chart_base_2d_brushable_x.html View 2 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/ui/base/column_chart_test.html View 6 chunks +7 lines, -7 lines 0 comments Download
M tracing/tracing/ui/base/draw_helpers.html View 4 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/base/line_chart_test.html View 5 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/ui/base/name_bar_chart.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/name_bar_chart_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/name_column_chart_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/name_line_chart_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/quad_stack_view.html View 7 chunks +11 lines, -11 lines 0 comments Download
M tracing/tracing/ui/base/scatter_chart.html View 3 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/ui/base/scatter_chart_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/timing_tool.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/base/utils.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html View 5 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/picture_debugger.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_summary_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/picture_ops_chart_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/drive/comments_side_panel.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/side_panel/alerts_side_panel.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/extras/side_panel/frame_data_side_panel.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/side_panel/frame_data_side_panel_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html View 5 chunks +7 lines, -7 lines 0 comments Download
M tracing/tracing/ui/extras/system_stats/system_stats_instance_track.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/side_panel/file_size_stats_side_panel.html View 2 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/ui/side_panel/metrics_side_panel.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/side_panel/side_panel_container.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/timeline_display_transform_animations.html View 3 chunks +9 lines, -8 lines 0 comments Download
M tracing/tracing/ui/timeline_interest_range.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/timeline_viewport.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/chart_series.html View 6 chunks +7 lines, -7 lines 0 comments Download
M tracing/tracing/ui/tracks/chart_series_y_axis.html View 4 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/tracks/chart_series_y_axis_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/letter_dot_track.html View 4 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/tracks/model_track.html View 5 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/ui/tracks/model_track_test.html View 6 chunks +24 lines, -23 lines 0 comments Download
M tracing/tracing/ui/tracks/multi_row_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/object_instance_group_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/object_instance_track.html View 6 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/ui/tracks/process_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/rect_track.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/tracks/slice_group_track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/stacked_bars_track.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/track.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/histogram.html View 23 chunks +34 lines, -33 lines 0 comments Download
M tracing/tracing/value/histogram_set_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/histogram_test.html View 7 chunks +40 lines, -40 lines 0 comments Download
M tracing/tracing/value/ui/histogram_set_table_row.html View 3 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/value/ui/histogram_set_table_row_state.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/value/ui/histogram_set_table_row_state_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/ui/histogram_set_table_test.html View 1 chunk +6 lines, -6 lines 0 comments Download
M tracing/tracing/value/ui/histogram_span.html View 7 chunks +9 lines, -9 lines 0 comments Download
M tracing/tracing/value/ui/scalar_context_controller.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/value/ui/scalar_context_controller_test.html View 7 chunks +16 lines, -16 lines 0 comments Download
M tracing/tracing/value/ui/scalar_map_table.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/value/ui/scalar_span.html View 3 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/value/ui/scalar_span_test.html View 21 chunks +43 lines, -43 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
hjd
ptal, mostly unchanged except for the new changes under trace_processor/ Thanks!
3 years, 9 months ago (2017-03-23 19:21:54 UTC) #2
benjhayden
lgtm
3 years, 9 months ago (2017-03-23 19:56:16 UTC) #3
charliea (OOO until 10-5)
lgtm
3 years, 9 months ago (2017-03-23 20:06:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771723003/40001
3 years, 9 months ago (2017-03-24 10:34:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/6657)
3 years, 9 months ago (2017-03-24 10:38:33 UTC) #9
hjd
Simon, could I get an OWNERS stamp for trace_processor/experimental/mappers/? Thanks! :)
3 years, 9 months ago (2017-03-24 12:16:39 UTC) #11
shatch
lgtm
3 years, 9 months ago (2017-03-24 12:46:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771723003/40001
3 years, 9 months ago (2017-03-24 13:17:43 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 13:20:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698