trace_processor/experimental/mappers/slice_cost.html - Issue 2771723003: [tracing] Move math utilities from base into their own subdirectory (attempt 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trace_processor/experimental/mappers/slice_cost.html

Issue 2771723003: [tracing] Move math utilities from base into their own subdirectory (attempt 2) (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trace_processor/experimental/mappers/slice_cost.html

diff --git a/trace_processor/experimental/mappers/slice_cost.html b/trace_processor/experimental/mappers/slice_cost.html

index d1f1ff8ff11116d584c09a2a6bc73991cbedd8bf..b741363fa5f04719624ad78e9c0e6967622e32b6 100644

--- a/trace_processor/experimental/mappers/slice_cost.html

+++ b/trace_processor/experimental/mappers/slice_cost.html

@@ -98,7 +98,7 @@ tr.exportTo('pi.m', function() {

function generateDomainCosts(slice) {

// V8.Execute events may generate several sliceCostInfo, based on the

// origin of the JS being executed.

- var range = new tr.b.Range();

+ var range = new tr.b.math.Range();

slice.addBoundsToRange(range);

var filtered = range.filterArray(

slice.parentContainer.samples,