tracing/tracing/metrics/webrtc/webrtc_rendering_metric.html - Issue 2771723003: [tracing] Move math utilities from base into their own subdirectory (attempt 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/webrtc/webrtc_rendering_metric.html

Issue 2771723003: [tracing] Move math utilities from base into their own subdirectory (attempt 2) (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/metrics/webrtc/webrtc_rendering_metric.html

diff --git a/tracing/tracing/metrics/webrtc/webrtc_rendering_metric.html b/tracing/tracing/metrics/webrtc/webrtc_rendering_metric.html

index 8747508f2c6add43801ccbf29b5802fbbcb95a6f..cccedf0e06f1481b69b59e9523d3f06453c6d5f3 100644

--- a/tracing/tracing/metrics/webrtc/webrtc_rendering_metric.html

+++ b/tracing/tracing/metrics/webrtc/webrtc_rendering_metric.html

@@ -5,7 +5,7 @@ Use of this source code is governed by a BSD-style license that can be

found in the LICENSE file.

-->

-<link rel="import" href="/tracing/base/range.html">

+<link rel="import" href="/tracing/base/math/range.html">

@@ -266,7 +266,7 @@ tr.exportTo('tr.metrics.webrtc', function() {

oldIdealRender = currentIdealRender;

}

- let discrepancySum = tr.b.Statistics.sum(discrepancy) - discrepancy[0];

+ let discrepancySum = tr.b.math.Statistics.sum(discrepancy) - discrepancy[0];

let lastIdealRender =

events[events.length - 1].args[IDEAL_RENDER_INSTANT_NAME];

let firstIdealRender = events[0].args[IDEAL_RENDER_INSTANT_NAME];

@@ -293,7 +293,7 @@ tr.exportTo('tr.metrics.webrtc', function() {

* percentOutOfSync and smoothnesScore calculated from the driftTimes array.

function getSmoothnessStats(driftTimes) {

- let meanDriftTime = tr.b.Statistics.mean(driftTimes);

+ let meanDriftTime = tr.b.math.Statistics.mean(driftTimes);

let normDriftTimes = driftTimes.map(driftTime =>

Math.abs(driftTime - meanDriftTime));