tracing/tracing/ui/timeline_viewport.html - Issue 2771723003: [tracing] Move math utilities from base into their own subdirectory (attempt 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/timeline_viewport.html

Issue 2771723003: [tracing] Move math utilities from base into their own subdirectory (attempt 2) (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/ui/timeline_viewport.html

diff --git a/tracing/tracing/ui/timeline_viewport.html b/tracing/tracing/ui/timeline_viewport.html

index 3e6925656fc1d057abb2ee780530d5d526c588bf..d22bc170fd1ee2db9f2d3f898bac479ad65839f8 100644

--- a/tracing/tracing/ui/timeline_viewport.html

+++ b/tracing/tracing/ui/timeline_viewport.html

@@ -190,7 +190,7 @@ tr.exportTo('tr.ui', function() {

onCurentDisplayTransformChange_: function(oldDisplayTransform) {

// Ensure panY stays clamped in the track container's scroll range.

if (this.modelTrackContainer_) {

- this.currentDisplayTransform.panY = tr.b.clamp(

+ this.currentDisplayTransform.panY = tr.b.math.clamp(

this.currentDisplayTransform.panY,

this.modelTrackContainer_.scrollHeight -

@@ -320,7 +320,7 @@ tr.exportTo('tr.ui', function() {

var idealMajorMarkDistanceWorld =

dt.xViewVectorToWorld(idealMajorMarkDistancePix);

- var majorMarkDistanceWorld = tr.b.preferredNumberLargerThanMin(

+ var majorMarkDistanceWorld = tr.b.math.preferredNumberLargerThanMin(

idealMajorMarkDistanceWorld);

var firstMajorMark = Math.floor(