tracing/tracing/metrics/system_health/cpu_time_metric.html - Issue 2771723003: [tracing] Move math utilities from base into their own subdirectory (attempt 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/system_health/cpu_time_metric.html

Issue 2771723003: [tracing] Move math utilities from base into their own subdirectory (attempt 2) (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/metrics/system_health/cpu_time_metric.html

diff --git a/tracing/tracing/metrics/system_health/cpu_time_metric.html b/tracing/tracing/metrics/system_health/cpu_time_metric.html

index d9f53028d903efc2fb52f3ff8c3662416d1ecbbe..778bdf6273ce3a5cd243f0a01c65b2ba9d5c9024 100644

--- a/tracing/tracing/metrics/system_health/cpu_time_metric.html

+++ b/tracing/tracing/metrics/system_health/cpu_time_metric.html

@@ -66,7 +66,8 @@ tr.exportTo('tr.metrics.sh', function() {

return;

if (!slice.cpuDuration)

return;

- var sliceRange = tr.b.Range.fromExplicitRange(slice.start, slice.end);

+ var sliceRange = tr.b.math.Range.fromExplicitRange(

+ slice.start, slice.end);

var intersection = rangeOfInterest.findIntersection(sliceRange);

var fractionOfSliceInsideRangeOfInterest =

intersection.duration / slice.duration;