Define default values for options dictionaries for WebAudio

Define default values for options dictionaries for WebAudio

The IDL definitions for dictionaries for the options for WebAudio constructors
were missing default values.

Update IDL to include the default values and update the code so that checks
aren't done when default values exist.

BUG=703677, 710471
TEST=AudioParam/audioparam-clamp-time-to-current-time.html

Review-Url: https://codereview.chromium.org/2760353002
Cr-Commit-Position: refs/heads/master@{#464437}
Committed: https://chromium.googlesource.com/chromium/src/+/ef006156fd62853a893617ca104f4ac2045e19c1

[Raymond Toy, 2017-03-21 17:10:35]

Description was changed from

==========
Define default values for OscillatorOptions

OscillatorOptions was missing the default values for the dictionary
members.

BUG=703677
TEST=AudioParam/audioparam-clamp-time-to-current-time.html
==========

to

==========
Define default values for options dictionaries for WebAudio

The IDL definitions for dictionaries for the options for WebAudio constructors
were missing default values.

Update IDL to include the default values and update the code so that checks
aren't done when default values exist.

BUG=703677
TEST=AudioParam/audioparam-clamp-time-to-current-time.html
==========

[Raymond Toy, 2017-03-21 17:10:59]

Description was changed from

==========
Define default values for options dictionaries for WebAudio

The IDL definitions for dictionaries for the options for WebAudio constructors
were missing default values.

Update IDL to include the default values and update the code so that checks
aren't done when default values exist.

BUG=703677
TEST=AudioParam/audioparam-clamp-time-to-current-time.html
==========

to

==========
Define default values for options dictionaries for WebAudio

The IDL definitions for dictionaries for the options for WebAudio constructors
were missing default values.

Update IDL to include the default values and update the code so that checks
aren't done when default values exist.

BUG=703677
TEST=AudioParam/audioparam-clamp-time-to-current-time.html
==========

[Raymond Toy, 2017-04-11 15:17:11]

Description was changed from

==========
Define default values for options dictionaries for WebAudio

The IDL definitions for dictionaries for the options for WebAudio constructors
were missing default values.

Update IDL to include the default values and update the code so that checks
aren't done when default values exist.

BUG=703677
TEST=AudioParam/audioparam-clamp-time-to-current-time.html
==========

to

==========
Define default values for options dictionaries for WebAudio

The IDL definitions for dictionaries for the options for WebAudio constructors
were missing default values.

Update IDL to include the default values and update the code so that checks
aren't done when default values exist.

BUG=703677, 710471
TEST=AudioParam/audioparam-clamp-time-to-current-time.html
==========

[Raymond Toy, 2017-04-12 14:40:10]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-04-12 14:40:11]

PTAL

[hongchan, 2017-04-12 16:37:53]

So I gather that if a property does not have a default value, we can't use this
trick?

In that case, if the setting value fails then the WebAudio code will throw the
error not the IDL layer. Correct?

https://codereview.chromium.org/2760353002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp (right):

https://codereview.chromium.org/2760353002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp:205:
node->setFftSize(options.fftSize(), exception_state);
Not relevant to this CL, but why 'set..' not 'Set..'?

[Raymond Toy, 2017-04-12 18:10:12]

As discussed offline, yes, if there's no default value we have to check to see
if a value is given and manually set some default for ourselves.  In this case
we get to throw the error for anything weird.

https://codereview.chromium.org/2760353002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp (right):

https://codereview.chromium.org/2760353002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp:205:
node->setFftSize(options.fftSize(), exception_state);
On 2017/04/12 16:37:53, hongchan wrote:
> Not relevant to this CL, but why 'set..' not 'Set..'?

Who knows? setFftSize didn't get changed by the Great Blink Renaming, so I'm not
going to do that.  Maybe because this is the method that is exposed to JS to
setting the fftSize attribute?

[hongchan, 2017-04-12 19:08:38]

lgtm

[Raymond Toy, 2017-04-12 19:25:11]

rtoy@chromium.org changed reviewers:
+ tkent@chromium.org

[Raymond Toy, 2017-04-12 19:25:12]

tkent: PTAL as API Owner

No intent was written for this minor change in the API.

This CL updates the constructor options dictionaries to specify default values. 
Most did not include default values, but with the cleanup of the AudioNode
constructors in the spec to make the factory methods be described in terms of
the constructors, the dictionaries needed to be updated to specify the default
values.

There aren't any user-visible changes; we internally set the defaults if the
value wasn't otherwise specified.

[tkent, 2017-04-13 00:35:46]

lgtm

[Raymond Toy, 2017-04-13 15:17:36]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-04-13 15:18:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 16:35:50]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492096656428180,
"parent_rev": "9c81c7f602788f3fc6e697a2da771e5b0e582a12", "commit_rev":
"ef006156fd62853a893617ca104f4ac2045e19c1"}

[commit-bot: I haz the power, 2017-04-13 16:36:40]

Description was changed from

==========
Define default values for options dictionaries for WebAudio

The IDL definitions for dictionaries for the options for WebAudio constructors
were missing default values.

Update IDL to include the default values and update the code so that checks
aren't done when default values exist.

BUG=703677, 710471
TEST=AudioParam/audioparam-clamp-time-to-current-time.html
==========

to

==========
Define default values for options dictionaries for WebAudio

The IDL definitions for dictionaries for the options for WebAudio constructors
were missing default values.

Update IDL to include the default values and update the code so that checks
aren't done when default values exist.

BUG=703677, 710471
TEST=AudioParam/audioparam-clamp-time-to-current-time.html

Review-Url: https://codereview.chromium.org/2760353002
Cr-Commit-Position: refs/heads/master@{#464437}
Committed:
https://chromium.googlesource.com/chromium/src/+/ef006156fd62853a893617ca104f...
==========

[commit-bot: I haz the power, 2017-04-13 16:36:41]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/ef006156fd62853a893617ca104f...