third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html - Issue 2760353002: Define default values for options dictionaries for WebAudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html

Issue 2760353002: Define default values for options dictionaries for WebAudio (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html b/third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html

index a7b8332e0e91034443e77619a8b969efcdc8aed1..7d9150523e5ec54aae44248bfa64255c54ec46cb 100644

--- a/third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html

+++ b/third_party/WebKit/LayoutTests/webaudio/constructor/oscillator.html

@@ -117,11 +117,12 @@

real: [1, 1]

})

};

- success = Should("new OscillatorNode(c, " + JSON.stringify(options) + ")",

+ success = Should("node2 = new OscillatorNode(c, " + JSON.stringify(options) + ")",

function () {

node = new OscillatorNode(context, options);

})

- .throw("InvalidStateError") && success;

+ .notThrow() && success;

+ Should("node2.type", node.type).beEqualTo("custom");

options = {

type: "custom"

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp » ('J')