Define default values for options dictionaries for WebAudio

third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 184 matching lines @@
                                    ExceptionState& exception_state) {
   DCHECK(IsMainThread());
 
   AnalyserNode* node = Create(*context, exception_state);
 
   if (!node)
     return nullptr;
 
   node->HandleChannelOptions(options, exception_state);
 
-  if (options.hasFftSize())
-    node->setFftSize(options.fftSize(), exception_state);
-
-  if (options.hasSmoothingTimeConstant())
-    node->setSmoothingTimeConstant(options.smoothingTimeConstant(),
-                                   exception_state);
+  node->setFftSize(options.fftSize(), exception_state);

[hongchan, 2017/04/12 16:37:53]

Not relevant to this CL, but why 'set..' not 'Set..'?

[Raymond Toy, 2017/04/12 18:10:12]

Who knows? setFftSize didn't get changed by the Great Blink Renaming, so I'm not
going to do that.  Maybe because this is the method that is exposed to JS to
setting the fftSize attribute?

+  node->setSmoothingTimeConstant(options.smoothingTimeConstant(),
+                                 exception_state);
 
   // minDecibels and maxDecibels have default values.  Set both of the values
   // at once.
   node->SetMinMaxDecibels(options.minDecibels(), options.maxDecibels(),
                           exception_state);
 
   return node;
 }
 
 AnalyserHandler& AnalyserNode::GetAnalyserHandler() const {
@@ skipping 54 matching lines @@
 
 void AnalyserNode::getFloatTimeDomainData(DOMFloat32Array* array) {
   GetAnalyserHandler().GetFloatTimeDomainData(array);
 }
 
 void AnalyserNode::getByteTimeDomainData(DOMUint8Array* array) {
   GetAnalyserHandler().GetByteTimeDomainData(array);
 }
 
 }  // namespace blink