Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/DelayNode.cpp

Issue 2760353002: Define default values for options dictionaries for WebAudio (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 const DelayOptions& options, 88 const DelayOptions& options,
89 ExceptionState& exception_state) { 89 ExceptionState& exception_state) {
90 // maxDelayTime has a default value specified. 90 // maxDelayTime has a default value specified.
91 DelayNode* node = Create(*context, options.maxDelayTime(), exception_state); 91 DelayNode* node = Create(*context, options.maxDelayTime(), exception_state);
92 92
93 if (!node) 93 if (!node)
94 return nullptr; 94 return nullptr;
95 95
96 node->HandleChannelOptions(options, exception_state); 96 node->HandleChannelOptions(options, exception_state);
97 97
98 if (options.hasDelayTime()) 98 node->delayTime()->setValue(options.delayTime());
99 node->delayTime()->setValue(options.delayTime());
100 99
101 return node; 100 return node;
102 } 101 }
103 102
104 AudioParam* DelayNode::delayTime() { 103 AudioParam* DelayNode::delayTime() {
105 return delay_time_; 104 return delay_time_;
106 } 105 }
107 106
108 DEFINE_TRACE(DelayNode) { 107 DEFINE_TRACE(DelayNode) {
109 visitor->Trace(delay_time_); 108 visitor->Trace(delay_time_);
110 AudioNode::Trace(visitor); 109 AudioNode::Trace(visitor);
111 } 110 }
112 111
113 } // namespace blink 112 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698