Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp

Issue 2760353002: Define default values for options dictionaries for WebAudio (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
index 788df87773b145f8d31f755dbce865829592f308..77b8fd590f0edb7eed5e04496d00af270a8028f1 100644
--- a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
@@ -191,16 +191,11 @@ DynamicsCompressorNode* DynamicsCompressorNode::Create(
node->HandleChannelOptions(options, exception_state);
- if (options.hasAttack())
- node->attack()->setValue(options.attack());
- if (options.hasKnee())
- node->knee()->setValue(options.knee());
- if (options.hasRatio())
- node->ratio()->setValue(options.ratio());
- if (options.hasRelease())
- node->release()->setValue(options.release());
- if (options.hasThreshold())
- node->threshold()->setValue(options.threshold());
+ node->attack()->setValue(options.attack());
+ node->knee()->setValue(options.knee());
+ node->ratio()->setValue(options.ratio());
+ node->release()->setValue(options.release());
+ node->threshold()->setValue(options.threshold());
return node;
}

Powered by Google App Engine
This is Rietveld 408576698