Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp

Issue 2760353002: Define default values for options dictionaries for WebAudio (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp b/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
index bb055acf08b994f1e2d9164e58085d5d8c641ae5..5d24ae60c9356918b8e1b23f0544f512edbba5e2 100644
--- a/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
@@ -78,16 +78,11 @@ BiquadFilterNode* BiquadFilterNode::Create(BaseAudioContext* context,
node->HandleChannelOptions(options, exception_state);
- if (options.hasType())
- node->setType(options.type());
- if (options.hasQ())
- node->q()->setValue(options.Q());
- if (options.hasDetune())
- node->detune()->setValue(options.detune());
- if (options.hasFrequency())
- node->frequency()->setValue(options.frequency());
- if (options.hasGain())
- node->gain()->setValue(options.gain());
+ node->setType(options.type());
+ node->q()->setValue(options.Q());
+ node->detune()->setValue(options.detune());
+ node->frequency()->setValue(options.frequency());
+ node->gain()->setValue(options.gain());
return node;
}

Powered by Google App Engine
This is Rietveld 408576698