third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp - Issue 2760353002: Define default values for options dictionaries for WebAudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

Issue 2760353002: Define default values for options dictionaries for WebAudio (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioBufferSourceOptions.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

index d0904f9c8937442c1c344e4dbdc44959cca07fb1..c5a6487d3a628cdce1237e8541560c8e1baedfb8 100644

--- a/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp

@@ -678,16 +678,11 @@ AudioBufferSourceNode* AudioBufferSourceNode::Create(

if (options.hasBuffer())

node->setBuffer(options.buffer(), exception_state);

- if (options.hasDetune())

- node->detune()->setValue(options.detune());

- if (options.hasLoop())

- node->setLoop(options.loop());

- if (options.hasLoopEnd())

- node->setLoopEnd(options.loopEnd());

- if (options.hasLoopStart())

- node->setLoopStart(options.loopStart());

- if (options.hasPlaybackRate())

- node->playbackRate()->setValue(options.playbackRate());

+ node->detune()->setValue(options.detune());

+ node->setLoop(options.loop());

+ node->setLoopEnd(options.loopEnd());

+ node->setLoopStart(options.loopStart());

+ node->playbackRate()->setValue(options.playbackRate());

return node;

}