Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp

Issue 2760353002: Define default values for options dictionaries for WebAudio (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp b/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp
index 822e8117b326ed224e4691260fa771803433cafc..01ebca82d3e2f636a5b6c02bc361de1a6155ed85 100644
--- a/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp
@@ -202,12 +202,9 @@ AnalyserNode* AnalyserNode::Create(BaseAudioContext* context,
node->HandleChannelOptions(options, exception_state);
- if (options.hasFftSize())
- node->setFftSize(options.fftSize(), exception_state);
-
- if (options.hasSmoothingTimeConstant())
- node->setSmoothingTimeConstant(options.smoothingTimeConstant(),
- exception_state);
+ node->setFftSize(options.fftSize(), exception_state);
hongchan 2017/04/12 16:37:53 Not relevant to this CL, but why 'set..' not 'Set.
Raymond Toy 2017/04/12 18:10:12 Who knows? setFftSize didn't get changed by the Gr
+ node->setSmoothingTimeConstant(options.smoothingTimeConstant(),
+ exception_state);
// minDecibels and maxDecibels have default values. Set both of the values
// at once.

Powered by Google App Engine
This is Rietveld 408576698