Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2752143004: [refactor] Separate generated builtins and C++ builtins into separate files (Closed)

Created:
3 years, 9 months ago by Jakob Kummerow
Modified:
3 years, 9 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[refactor] Separate generated builtins and C++ builtins into separate files This is in preparation for linking the former only into mksnapshot. Just shuffling code around, no changes in functionality. BUG=v8:6055 Review-Url: https://codereview.chromium.org/2752143004 Cr-Commit-Position: refs/heads/master@{#43858} Committed: https://chromium.googlesource.com/v8/v8/+/b3507ff022d26a3c90fb3b8e987d2c805aded722

Patch Set 1 #

Patch Set 2 : fix 'builtins-regexp-gen.h' in BUILD.gn #

Patch Set 3 : tentative gcmole fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1901 lines, -17227 lines) Patch
M BUILD.gn View 1 2 5 chunks +51 lines, -14 lines 0 comments Download
M src/builtins/builtins.cc View 1 chunk +71 lines, -0 lines 0 comments Download
D src/builtins/builtins-arguments.cc View 1 chunk +0 lines, -425 lines 0 comments Download
A + src/builtins/builtins-arguments-gen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-array.cc View 3 chunks +0 lines, -1505 lines 0 comments Download
A + src/builtins/builtins-array-gen.cc View 3 chunks +177 lines, -1407 lines 0 comments Download
M src/builtins/builtins-async.h View 1 chunk +1 line, -1 line 0 comments Download
D src/builtins/builtins-async.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D src/builtins/builtins-async-function.cc View 1 chunk +0 lines, -208 lines 0 comments Download
A + src/builtins/builtins-async-function-gen.cc View 2 chunks +2 lines, -6 lines 0 comments Download
A + src/builtins/builtins-async-gen.cc View 1 chunk +2 lines, -5 lines 0 comments Download
D src/builtins/builtins-async-iterator.cc View 1 chunk +0 lines, -326 lines 0 comments Download
A + src/builtins/builtins-async-iterator-gen.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M src/builtins/builtins-boolean.cc View 2 chunks +0 lines, -30 lines 0 comments Download
A src/builtins/builtins-boolean-gen.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M src/builtins/builtins-constructor.h View 3 chunks +5 lines, -10 lines 0 comments Download
D src/builtins/builtins-constructor.cc View 1 chunk +0 lines, -794 lines 0 comments Download
A + src/builtins/builtins-constructor-gen.cc View 8 chunks +9 lines, -62 lines 0 comments Download
D src/builtins/builtins-conversion.cc View 1 chunk +0 lines, -411 lines 0 comments Download
A + src/builtins/builtins-conversion-gen.cc View 3 chunks +1 line, -25 lines 0 comments Download
M src/builtins/builtins-date.cc View 2 chunks +0 lines, -204 lines 0 comments Download
A src/builtins/builtins-date-gen.cc View 1 chunk +220 lines, -0 lines 0 comments Download
D src/builtins/builtins-forin.cc View 1 chunk +0 lines, -222 lines 0 comments Download
A + src/builtins/builtins-forin-gen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-function.cc View 3 chunks +0 lines, -166 lines 0 comments Download
A src/builtins/builtins-function-gen.cc View 1 chunk +178 lines, -0 lines 0 comments Download
D src/builtins/builtins-generator.cc View 1 chunk +0 lines, -116 lines 0 comments Download
A + src/builtins/builtins-generator-gen.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/builtins/builtins-global.cc View 2 chunks +0 lines, -96 lines 0 comments Download
A src/builtins/builtins-global-gen.cc View 1 chunk +108 lines, -0 lines 0 comments Download
D src/builtins/builtins-handler.cc View 1 chunk +0 lines, -209 lines 0 comments Download
A + src/builtins/builtins-handler-gen.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/builtins/builtins-ic.cc View 1 chunk +0 lines, -52 lines 0 comments Download
A + src/builtins/builtins-ic-gen.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins/builtins-internal.cc View 2 chunks +0 lines, -161 lines 0 comments Download
A + src/builtins/builtins-internal-gen.cc View 1 chunk +3 lines, -34 lines 0 comments Download
M src/builtins/builtins-math.cc View 3 chunks +0 lines, -461 lines 0 comments Download
A + src/builtins/builtins-math-gen.cc View 2 chunks +2 lines, -56 lines 0 comments Download
M src/builtins/builtins-number.cc View 3 chunks +0 lines, -1373 lines 0 comments Download
A + src/builtins/builtins-number-gen.cc View 3 chunks +5 lines, -218 lines 0 comments Download
M src/builtins/builtins-object.cc View 3 chunks +0 lines, -397 lines 0 comments Download
A src/builtins/builtins-object-gen.cc View 1 chunk +413 lines, -0 lines 0 comments Download
M src/builtins/builtins-promise.h View 2 chunks +1 line, -3 lines 0 comments Download
D src/builtins/builtins-promise.cc View 1 chunk +0 lines, -1762 lines 0 comments Download
A + src/builtins/builtins-promise-gen.cc View 3 chunks +4 lines, -3 lines 0 comments Download
D src/builtins/builtins-regexp.h View 1 chunk +0 lines, -110 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 3 chunks +85 lines, -2754 lines 0 comments Download
A + src/builtins/builtins-regexp-gen.h View 1 chunk +1 line, -5 lines 0 comments Download
A + src/builtins/builtins-regexp-gen.cc View 5 chunks +35 lines, -157 lines 0 comments Download
M src/builtins/builtins-sharedarraybuffer.cc View 3 chunks +0 lines, -313 lines 0 comments Download
A src/builtins/builtins-sharedarraybuffer-gen.cc View 1 chunk +326 lines, -0 lines 0 comments Download
M src/builtins/builtins-string.cc View 7 chunks +0 lines, -1603 lines 0 comments Download
A + src/builtins/builtins-string-gen.cc View 8 chunks +31 lines, -581 lines 0 comments Download
M src/builtins/builtins-symbol.cc View 2 chunks +0 lines, -32 lines 0 comments Download
A src/builtins/builtins-symbol-gen.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M src/builtins/builtins-typedarray.cc View 3 chunks +0 lines, -568 lines 0 comments Download
A + src/builtins/builtins-typedarray-gen.cc View 4 chunks +5 lines, -166 lines 0 comments Download
M src/builtins/builtins-utils.h View 2 chunks +0 lines, -29 lines 0 comments Download
A src/builtins/builtins-utils-gen.h View 1 chunk +43 lines, -0 lines 0 comments Download
D src/builtins/builtins-wasm.cc View 1 chunk +0 lines, -30 lines 0 comments Download
A + src/builtins/builtins-wasm-gen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +28 lines, -13 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Jakob Kummerow
PTAL :-)
3 years, 9 months ago (2017-03-16 10:10:04 UTC) #2
jgruber
lgtm
3 years, 9 months ago (2017-03-16 10:14:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752143004/20001
3 years, 9 months ago (2017-03-16 10:18:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/22567) v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 9 months ago (2017-03-16 10:51:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752143004/40001
3 years, 9 months ago (2017-03-16 11:04:31 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 11:32:10 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/b3507ff022d26a3c90fb3b8e987d2c805ad...

Powered by Google App Engine
This is Rietveld 408576698