Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: src/builtins/builtins-sharedarraybuffer.cc

Issue 2752143004: [refactor] Separate generated builtins and C++ builtins into separate files (Closed)
Patch Set: tentative gcmole fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-regexp-gen.cc ('k') | src/builtins/builtins-sharedarraybuffer-gen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-sharedarraybuffer.cc
diff --git a/src/builtins/builtins-sharedarraybuffer.cc b/src/builtins/builtins-sharedarraybuffer.cc
index 3c909a91e9d3bde61742a21581cf57072e05563a..4c0043471247002855f5191bc43314e3b642392f 100644
--- a/src/builtins/builtins-sharedarraybuffer.cc
+++ b/src/builtins/builtins-sharedarraybuffer.cc
@@ -8,7 +8,6 @@
#include "src/builtins/builtins-utils.h"
#include "src/builtins/builtins.h"
#include "src/code-factory.h"
-#include "src/code-stub-assembler.h"
#include "src/conversions-inl.h"
#include "src/counters.h"
#include "src/factory.h"
@@ -19,24 +18,6 @@
namespace v8 {
namespace internal {
-using compiler::Node;
-
-class SharedArrayBufferBuiltinsAssembler : public CodeStubAssembler {
- public:
- explicit SharedArrayBufferBuiltinsAssembler(
- compiler::CodeAssemblerState* state)
- : CodeStubAssembler(state) {}
-
- protected:
- void ValidateSharedTypedArray(Node* tagged, Node* context,
- Node** out_instance_type,
- Node** out_backing_store);
- Node* ConvertTaggedAtomicIndexToWord32(Node* tagged, Node* context,
- Node** number_index);
- void ValidateAtomicIndex(Node* index_word, Node* array_length_word,
- Node* context);
-};
-
// ES7 sharedmem 6.3.4.1 get SharedArrayBuffer.prototype.byteLength
BUILTIN(SharedArrayBufferPrototypeGetByteLength) {
HandleScope scope(isolate);
@@ -52,300 +33,6 @@ BUILTIN(SharedArrayBufferPrototypeGetByteLength) {
return array_buffer->byte_length();
}
-void SharedArrayBufferBuiltinsAssembler::ValidateSharedTypedArray(
- Node* tagged, Node* context, Node** out_instance_type,
- Node** out_backing_store) {
- Label not_float_or_clamped(this), invalid(this);
-
- // Fail if it is not a heap object.
- GotoIf(TaggedIsSmi(tagged), &invalid);
-
- // Fail if the array's instance type is not JSTypedArray.
- GotoIf(Word32NotEqual(LoadInstanceType(tagged),
- Int32Constant(JS_TYPED_ARRAY_TYPE)),
- &invalid);
-
- // Fail if the array's JSArrayBuffer is not shared.
- Node* array_buffer = LoadObjectField(tagged, JSTypedArray::kBufferOffset);
- Node* bitfield = LoadObjectField(array_buffer, JSArrayBuffer::kBitFieldOffset,
- MachineType::Uint32());
- GotoIfNot(IsSetWord32<JSArrayBuffer::IsShared>(bitfield), &invalid);
-
- // Fail if the array's element type is float32, float64 or clamped.
- Node* elements_instance_type =
- LoadInstanceType(LoadObjectField(tagged, JSObject::kElementsOffset));
- STATIC_ASSERT(FIXED_INT8_ARRAY_TYPE < FIXED_FLOAT32_ARRAY_TYPE);
- STATIC_ASSERT(FIXED_INT16_ARRAY_TYPE < FIXED_FLOAT32_ARRAY_TYPE);
- STATIC_ASSERT(FIXED_INT32_ARRAY_TYPE < FIXED_FLOAT32_ARRAY_TYPE);
- STATIC_ASSERT(FIXED_UINT8_ARRAY_TYPE < FIXED_FLOAT32_ARRAY_TYPE);
- STATIC_ASSERT(FIXED_UINT16_ARRAY_TYPE < FIXED_FLOAT32_ARRAY_TYPE);
- STATIC_ASSERT(FIXED_UINT32_ARRAY_TYPE < FIXED_FLOAT32_ARRAY_TYPE);
- Branch(Int32LessThan(elements_instance_type,
- Int32Constant(FIXED_FLOAT32_ARRAY_TYPE)),
- &not_float_or_clamped, &invalid);
-
- Bind(&invalid);
- {
- CallRuntime(Runtime::kThrowNotIntegerSharedTypedArrayError, context,
- tagged);
- Unreachable();
- }
-
- Bind(&not_float_or_clamped);
- *out_instance_type = elements_instance_type;
-
- Node* backing_store =
- LoadObjectField(array_buffer, JSArrayBuffer::kBackingStoreOffset);
- Node* byte_offset = ChangeUint32ToWord(TruncateTaggedToWord32(
- context, LoadObjectField(tagged, JSArrayBufferView::kByteOffsetOffset)));
- *out_backing_store =
- IntPtrAdd(BitcastTaggedToWord(backing_store), byte_offset);
-}
-
-// https://tc39.github.io/ecmascript_sharedmem/shmem.html#Atomics.ValidateAtomicAccess
-Node* SharedArrayBufferBuiltinsAssembler::ConvertTaggedAtomicIndexToWord32(
- Node* tagged, Node* context, Node** number_index) {
- Variable var_result(this, MachineRepresentation::kWord32);
-
- // TODO(jkummerow): Skip ToNumber call when |tagged| is a number already.
- // Maybe this can be unified with other tagged-to-index conversions?
- // Why does this return an int32, and not an intptr?
- // Why is there the additional |number_index| output parameter?
- Callable to_number = CodeFactory::ToNumber(isolate());
- *number_index = CallStub(to_number, context, tagged);
- Label done(this, &var_result);
-
- Label if_numberissmi(this), if_numberisnotsmi(this);
- Branch(TaggedIsSmi(*number_index), &if_numberissmi, &if_numberisnotsmi);
-
- Bind(&if_numberissmi);
- {
- var_result.Bind(SmiToWord32(*number_index));
- Goto(&done);
- }
-
- Bind(&if_numberisnotsmi);
- {
- Node* number_index_value = LoadHeapNumberValue(*number_index);
- Node* access_index = TruncateFloat64ToWord32(number_index_value);
- Node* test_index = ChangeInt32ToFloat64(access_index);
-
- Label if_indexesareequal(this), if_indexesarenotequal(this);
- Branch(Float64Equal(number_index_value, test_index), &if_indexesareequal,
- &if_indexesarenotequal);
-
- Bind(&if_indexesareequal);
- {
- var_result.Bind(access_index);
- Goto(&done);
- }
-
- Bind(&if_indexesarenotequal);
- {
- CallRuntime(Runtime::kThrowInvalidAtomicAccessIndexError, context);
- Unreachable();
- }
- }
-
- Bind(&done);
- return var_result.value();
-}
-
-void SharedArrayBufferBuiltinsAssembler::ValidateAtomicIndex(
- Node* index_word, Node* array_length_word, Node* context) {
- // Check if the index is in bounds. If not, throw RangeError.
- Label check_passed(this);
- GotoIf(Uint32LessThan(index_word, array_length_word), &check_passed);
-
- CallRuntime(Runtime::kThrowInvalidAtomicAccessIndexError, context);
- Unreachable();
-
- Bind(&check_passed);
-}
-
-TF_BUILTIN(AtomicsLoad, SharedArrayBufferBuiltinsAssembler) {
- Node* array = Parameter(1);
- Node* index = Parameter(2);
- Node* context = Parameter(3 + 2);
-
- Node* instance_type;
- Node* backing_store;
- ValidateSharedTypedArray(array, context, &instance_type, &backing_store);
-
- Node* index_integer;
- Node* index_word32 =
- ConvertTaggedAtomicIndexToWord32(index, context, &index_integer);
- Node* array_length_word32 = TruncateTaggedToWord32(
- context, LoadObjectField(array, JSTypedArray::kLengthOffset));
- ValidateAtomicIndex(index_word32, array_length_word32, context);
- Node* index_word = ChangeUint32ToWord(index_word32);
-
- Label i8(this), u8(this), i16(this), u16(this), i32(this), u32(this),
- other(this);
- int32_t case_values[] = {
- FIXED_INT8_ARRAY_TYPE, FIXED_UINT8_ARRAY_TYPE, FIXED_INT16_ARRAY_TYPE,
- FIXED_UINT16_ARRAY_TYPE, FIXED_INT32_ARRAY_TYPE, FIXED_UINT32_ARRAY_TYPE,
- };
- Label* case_labels[] = {
- &i8, &u8, &i16, &u16, &i32, &u32,
- };
- Switch(instance_type, &other, case_values, case_labels,
- arraysize(case_labels));
-
- Bind(&i8);
- Return(SmiFromWord32(
- AtomicLoad(MachineType::Int8(), backing_store, index_word)));
-
- Bind(&u8);
- Return(SmiFromWord32(
- AtomicLoad(MachineType::Uint8(), backing_store, index_word)));
-
- Bind(&i16);
- Return(SmiFromWord32(
- AtomicLoad(MachineType::Int16(), backing_store, WordShl(index_word, 1))));
-
- Bind(&u16);
- Return(SmiFromWord32(AtomicLoad(MachineType::Uint16(), backing_store,
- WordShl(index_word, 1))));
-
- Bind(&i32);
- Return(ChangeInt32ToTagged(
- AtomicLoad(MachineType::Int32(), backing_store, WordShl(index_word, 2))));
-
- Bind(&u32);
- Return(ChangeUint32ToTagged(AtomicLoad(MachineType::Uint32(), backing_store,
- WordShl(index_word, 2))));
-
- // This shouldn't happen, we've already validated the type.
- Bind(&other);
- Unreachable();
-}
-
-TF_BUILTIN(AtomicsStore, SharedArrayBufferBuiltinsAssembler) {
- Node* array = Parameter(1);
- Node* index = Parameter(2);
- Node* value = Parameter(3);
- Node* context = Parameter(4 + 2);
-
- Node* instance_type;
- Node* backing_store;
- ValidateSharedTypedArray(array, context, &instance_type, &backing_store);
-
- Node* index_integer;
- Node* index_word32 =
- ConvertTaggedAtomicIndexToWord32(index, context, &index_integer);
- Node* array_length_word32 = TruncateTaggedToWord32(
- context, LoadObjectField(array, JSTypedArray::kLengthOffset));
- ValidateAtomicIndex(index_word32, array_length_word32, context);
- Node* index_word = ChangeUint32ToWord(index_word32);
-
- Node* value_integer = ToInteger(context, value);
- Node* value_word32 = TruncateTaggedToWord32(context, value_integer);
-
- Label u8(this), u16(this), u32(this), other(this);
- int32_t case_values[] = {
- FIXED_INT8_ARRAY_TYPE, FIXED_UINT8_ARRAY_TYPE, FIXED_INT16_ARRAY_TYPE,
- FIXED_UINT16_ARRAY_TYPE, FIXED_INT32_ARRAY_TYPE, FIXED_UINT32_ARRAY_TYPE,
- };
- Label* case_labels[] = {
- &u8, &u8, &u16, &u16, &u32, &u32,
- };
- Switch(instance_type, &other, case_values, case_labels,
- arraysize(case_labels));
-
- Bind(&u8);
- AtomicStore(MachineRepresentation::kWord8, backing_store, index_word,
- value_word32);
- Return(value_integer);
-
- Bind(&u16);
- AtomicStore(MachineRepresentation::kWord16, backing_store,
- WordShl(index_word, 1), value_word32);
- Return(value_integer);
-
- Bind(&u32);
- AtomicStore(MachineRepresentation::kWord32, backing_store,
- WordShl(index_word, 2), value_word32);
- Return(value_integer);
-
- // This shouldn't happen, we've already validated the type.
- Bind(&other);
- Unreachable();
-}
-
-TF_BUILTIN(AtomicsExchange, SharedArrayBufferBuiltinsAssembler) {
- Node* array = Parameter(1);
- Node* index = Parameter(2);
- Node* value = Parameter(3);
- Node* context = Parameter(4 + 2);
-
- Node* instance_type;
- Node* backing_store;
- ValidateSharedTypedArray(array, context, &instance_type, &backing_store);
-
- Node* index_integer;
- Node* index_word32 =
- ConvertTaggedAtomicIndexToWord32(index, context, &index_integer);
- Node* array_length_word32 = TruncateTaggedToWord32(
- context, LoadObjectField(array, JSTypedArray::kLengthOffset));
- ValidateAtomicIndex(index_word32, array_length_word32, context);
-
- Node* value_integer = ToInteger(context, value);
-
-#if V8_TARGET_ARCH_MIPS || V8_TARGET_ARCH_MIPS64 || V8_TARGET_ARCH_PPC64 || \
- V8_TARGET_ARCH_PPC
- Return(CallRuntime(Runtime::kAtomicsExchange, context, array, index_integer,
- value_integer));
-#else
- Node* index_word = ChangeUint32ToWord(index_word32);
-
- Node* value_word32 = TruncateTaggedToWord32(context, value_integer);
-
- Label i8(this), u8(this), i16(this), u16(this), i32(this), u32(this),
- other(this);
- int32_t case_values[] = {
- FIXED_INT8_ARRAY_TYPE, FIXED_UINT8_ARRAY_TYPE, FIXED_INT16_ARRAY_TYPE,
- FIXED_UINT16_ARRAY_TYPE, FIXED_INT32_ARRAY_TYPE, FIXED_UINT32_ARRAY_TYPE,
- };
- Label* case_labels[] = {
- &i8, &u8, &i16, &u16, &i32, &u32,
- };
- Switch(instance_type, &other, case_values, case_labels,
- arraysize(case_labels));
-
- Bind(&i8);
- Return(SmiFromWord32(AtomicExchange(MachineType::Int8(), backing_store,
- index_word, value_word32)));
-
- Bind(&u8);
- Return(SmiFromWord32(AtomicExchange(MachineType::Uint8(), backing_store,
- index_word, value_word32)));
-
- Bind(&i16);
- Return(SmiFromWord32(AtomicExchange(MachineType::Int16(), backing_store,
- WordShl(index_word, 1), value_word32)));
-
- Bind(&u16);
- Return(SmiFromWord32(AtomicExchange(MachineType::Uint16(), backing_store,
- WordShl(index_word, 1), value_word32)));
-
- Bind(&i32);
- Return(ChangeInt32ToTagged(AtomicExchange(MachineType::Int32(), backing_store,
- WordShl(index_word, 2),
- value_word32)));
-
- Bind(&u32);
- Return(ChangeUint32ToTagged(
- AtomicExchange(MachineType::Uint32(), backing_store,
- WordShl(index_word, 2), value_word32)));
-
- // This shouldn't happen, we've already validated the type.
- Bind(&other);
- Unreachable();
-#endif // V8_TARGET_ARCH_MIPS || V8_TARGET_ARCH_MIPS64 || V8_TARGET_ARCH_PPC64
- // || V8_TARGET_ARCH_PPC || V8_TARGET_ARCH_S390 || V8_TARGET_ARCH_S390X
-}
-
inline bool AtomicIsLockFree(uint32_t size) {
return size == 1 || size == 2 || size == 4;
}
« no previous file with comments | « src/builtins/builtins-regexp-gen.cc ('k') | src/builtins/builtins-sharedarraybuffer-gen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698