Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: src/builtins/builtins-utils.h

Issue 2752143004: [refactor] Separate generated builtins and C++ builtins into separate files (Closed)
Patch Set: tentative gcmole fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-typedarray-gen.cc ('k') | src/builtins/builtins-utils-gen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-utils.h
diff --git a/src/builtins/builtins-utils.h b/src/builtins/builtins-utils.h
index 7a2424deb6ea86f5671809038a4d9ff2af06b6ec..b2f268e29f92a71fa80178fbe05e0775b4efd24d 100644
--- a/src/builtins/builtins-utils.h
+++ b/src/builtins/builtins-utils.h
@@ -14,10 +14,6 @@
namespace v8 {
namespace internal {
-namespace compiler {
-class CodeAssemblerState;
-}
-
// Arguments object passed to C++ builtins.
class BuiltinArguments : public Arguments {
public:
@@ -107,31 +103,6 @@ class BuiltinArguments : public Arguments {
Isolate* isolate)
// ----------------------------------------------------------------------------
-// Support macro for defining builtins with Turbofan.
-// ----------------------------------------------------------------------------
-//
-// A builtin function is defined by writing:
-//
-// TF_BUILTIN(name, code_assember_base_class) {
-// ...
-// }
-//
-// In the body of the builtin function the arguments can be accessed
-// as "Parameter(n)".
-#define TF_BUILTIN(Name, AssemblerBase) \
- class Name##Assembler : public AssemblerBase { \
- public: \
- explicit Name##Assembler(compiler::CodeAssemblerState* state) \
- : AssemblerBase(state) {} \
- void Generate##Name##Impl(); \
- }; \
- void Builtins::Generate_##Name(compiler::CodeAssemblerState* state) { \
- Name##Assembler assembler(state); \
- assembler.Generate##Name##Impl(); \
- } \
- void Name##Assembler::Generate##Name##Impl()
-
-// ----------------------------------------------------------------------------
#define CHECK_RECEIVER(Type, name, method) \
if (!args.receiver()->Is##Type()) { \
« no previous file with comments | « src/builtins/builtins-typedarray-gen.cc ('k') | src/builtins/builtins-utils-gen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698