Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: src/builtins/builtins-global-gen.cc

Issue 2752143004: [refactor] Separate generated builtins and C++ builtins into separate files (Closed)
Patch Set: tentative gcmole fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-global.cc ('k') | src/builtins/builtins-handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-global-gen.cc
diff --git a/src/builtins/builtins-global-gen.cc b/src/builtins/builtins-global-gen.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2f27c5c60f4ab986cf85e1b29c73656c02b8e58b
--- /dev/null
+++ b/src/builtins/builtins-global-gen.cc
@@ -0,0 +1,108 @@
+// Copyright 2017 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "src/builtins/builtins-utils-gen.h"
+#include "src/builtins/builtins.h"
+#include "src/code-stub-assembler.h"
+
+namespace v8 {
+namespace internal {
+
+// ES6 section 18.2.2 isFinite ( number )
+TF_BUILTIN(GlobalIsFinite, CodeStubAssembler) {
+ Node* context = Parameter(4);
+
+ Label return_true(this), return_false(this);
+
+ // We might need to loop once for ToNumber conversion.
+ Variable var_num(this, MachineRepresentation::kTagged);
+ Label loop(this, &var_num);
+ var_num.Bind(Parameter(1));
+ Goto(&loop);
+ Bind(&loop);
+ {
+ Node* num = var_num.value();
+
+ // Check if {num} is a Smi or a HeapObject.
+ GotoIf(TaggedIsSmi(num), &return_true);
+
+ // Check if {num} is a HeapNumber.
+ Label if_numisheapnumber(this),
+ if_numisnotheapnumber(this, Label::kDeferred);
+ Branch(IsHeapNumberMap(LoadMap(num)), &if_numisheapnumber,
+ &if_numisnotheapnumber);
+
+ Bind(&if_numisheapnumber);
+ {
+ // Check if {num} contains a finite, non-NaN value.
+ Node* num_value = LoadHeapNumberValue(num);
+ BranchIfFloat64IsNaN(Float64Sub(num_value, num_value), &return_false,
+ &return_true);
+ }
+
+ Bind(&if_numisnotheapnumber);
+ {
+ // Need to convert {num} to a Number first.
+ Callable callable = CodeFactory::NonNumberToNumber(isolate());
+ var_num.Bind(CallStub(callable, context, num));
+ Goto(&loop);
+ }
+ }
+
+ Bind(&return_true);
+ Return(BooleanConstant(true));
+
+ Bind(&return_false);
+ Return(BooleanConstant(false));
+}
+
+// ES6 section 18.2.3 isNaN ( number )
+TF_BUILTIN(GlobalIsNaN, CodeStubAssembler) {
+ Node* context = Parameter(4);
+
+ Label return_true(this), return_false(this);
+
+ // We might need to loop once for ToNumber conversion.
+ Variable var_num(this, MachineRepresentation::kTagged);
+ Label loop(this, &var_num);
+ var_num.Bind(Parameter(1));
+ Goto(&loop);
+ Bind(&loop);
+ {
+ Node* num = var_num.value();
+
+ // Check if {num} is a Smi or a HeapObject.
+ GotoIf(TaggedIsSmi(num), &return_false);
+
+ // Check if {num} is a HeapNumber.
+ Label if_numisheapnumber(this),
+ if_numisnotheapnumber(this, Label::kDeferred);
+ Branch(IsHeapNumberMap(LoadMap(num)), &if_numisheapnumber,
+ &if_numisnotheapnumber);
+
+ Bind(&if_numisheapnumber);
+ {
+ // Check if {num} contains a NaN.
+ Node* num_value = LoadHeapNumberValue(num);
+ BranchIfFloat64IsNaN(num_value, &return_true, &return_false);
+ }
+
+ Bind(&if_numisnotheapnumber);
+ {
+ // Need to convert {num} to a Number first.
+ Callable callable = CodeFactory::NonNumberToNumber(isolate());
+ var_num.Bind(CallStub(callable, context, num));
+ Goto(&loop);
+ }
+ }
+
+ Bind(&return_true);
+ Return(BooleanConstant(true));
+
+ Bind(&return_false);
+ Return(BooleanConstant(false));
+}
+
+} // namespace internal
+} // namespace v8
« no previous file with comments | « src/builtins/builtins-global.cc ('k') | src/builtins/builtins-handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698