Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: src/builtins/builtins-generator.cc

Issue 2752143004: [refactor] Separate generated builtins and C++ builtins into separate files (Closed)
Patch Set: tentative gcmole fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-function-gen.cc ('k') | src/builtins/builtins-generator-gen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-generator.cc
diff --git a/src/builtins/builtins-generator.cc b/src/builtins/builtins-generator.cc
deleted file mode 100644
index 14a11edff3bd390c4375c2cddd52410d99d7988e..0000000000000000000000000000000000000000
--- a/src/builtins/builtins-generator.cc
+++ /dev/null
@@ -1,116 +0,0 @@
-// Copyright 2016 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "src/builtins/builtins-utils.h"
-#include "src/builtins/builtins.h"
-#include "src/code-factory.h"
-#include "src/code-stub-assembler.h"
-#include "src/isolate.h"
-#include "src/objects-inl.h"
-
-namespace v8 {
-namespace internal {
-
-typedef compiler::CodeAssemblerState CodeAssemblerState;
-
-class GeneratorBuiltinsAssembler : public CodeStubAssembler {
- public:
- explicit GeneratorBuiltinsAssembler(CodeAssemblerState* state)
- : CodeStubAssembler(state) {}
-
- protected:
- void GeneratorPrototypeResume(JSGeneratorObject::ResumeMode resume_mode,
- char const* const method_name);
-};
-
-void GeneratorBuiltinsAssembler::GeneratorPrototypeResume(
- JSGeneratorObject::ResumeMode resume_mode, char const* const method_name) {
- Node* receiver = Parameter(0);
- Node* value = Parameter(1);
- Node* context = Parameter(4);
- Node* closed = SmiConstant(JSGeneratorObject::kGeneratorClosed);
-
- // Check if the {receiver} is actually a JSGeneratorObject.
- Label if_receiverisincompatible(this, Label::kDeferred);
- GotoIf(TaggedIsSmi(receiver), &if_receiverisincompatible);
- Node* receiver_instance_type = LoadInstanceType(receiver);
- GotoIfNot(Word32Equal(receiver_instance_type,
- Int32Constant(JS_GENERATOR_OBJECT_TYPE)),
- &if_receiverisincompatible);
-
- // Check if the {receiver} is running or already closed.
- Node* receiver_continuation =
- LoadObjectField(receiver, JSGeneratorObject::kContinuationOffset);
- Label if_receiverisclosed(this, Label::kDeferred),
- if_receiverisrunning(this, Label::kDeferred);
- GotoIf(SmiEqual(receiver_continuation, closed), &if_receiverisclosed);
- DCHECK_LT(JSGeneratorObject::kGeneratorExecuting,
- JSGeneratorObject::kGeneratorClosed);
- GotoIf(SmiLessThan(receiver_continuation, closed), &if_receiverisrunning);
-
- // Resume the {receiver} using our trampoline.
- Node* result = CallStub(CodeFactory::ResumeGenerator(isolate()), context,
- value, receiver, SmiConstant(resume_mode));
- Return(result);
-
- Bind(&if_receiverisincompatible);
- {
- // The {receiver} is not a valid JSGeneratorObject.
- CallRuntime(Runtime::kThrowIncompatibleMethodReceiver, context,
- HeapConstant(
- factory()->NewStringFromAsciiChecked(method_name, TENURED)),
- receiver);
- Unreachable();
- }
-
- Bind(&if_receiverisclosed);
- {
- Callable create_iter_result_object =
- CodeFactory::CreateIterResultObject(isolate());
-
- // The {receiver} is closed already.
- Node* result = nullptr;
- switch (resume_mode) {
- case JSGeneratorObject::kNext:
- result = CallStub(create_iter_result_object, context,
- UndefinedConstant(), TrueConstant());
- break;
- case JSGeneratorObject::kReturn:
- result =
- CallStub(create_iter_result_object, context, value, TrueConstant());
- break;
- case JSGeneratorObject::kThrow:
- result = CallRuntime(Runtime::kThrow, context, value);
- break;
- }
- Return(result);
- }
-
- Bind(&if_receiverisrunning);
- {
- CallRuntime(Runtime::kThrowGeneratorRunning, context);
- Unreachable();
- }
-}
-
-// ES6 section 25.3.1.2 Generator.prototype.next ( value )
-TF_BUILTIN(GeneratorPrototypeNext, GeneratorBuiltinsAssembler) {
- GeneratorPrototypeResume(JSGeneratorObject::kNext,
- "[Generator].prototype.next");
-}
-
-// ES6 section 25.3.1.3 Generator.prototype.return ( value )
-TF_BUILTIN(GeneratorPrototypeReturn, GeneratorBuiltinsAssembler) {
- GeneratorPrototypeResume(JSGeneratorObject::kReturn,
- "[Generator].prototype.return");
-}
-
-// ES6 section 25.3.1.4 Generator.prototype.throw ( exception )
-TF_BUILTIN(GeneratorPrototypeThrow, GeneratorBuiltinsAssembler) {
- GeneratorPrototypeResume(JSGeneratorObject::kThrow,
- "[Generator].prototype.throw");
-}
-
-} // namespace internal
-} // namespace v8
« no previous file with comments | « src/builtins/builtins-function-gen.cc ('k') | src/builtins/builtins-generator-gen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698