Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params. (Closed)

Created:
3 years, 9 months ago by Steven Holte
Modified:
3 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, halliwell+watch_chromium.org, lcwu+watch_chromium.org, pkl (ping after 24h if needed), net-reviews_chromium.org, noyau+watch_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, marq+watch_chromium.org, alokp+watch_chromium.org, android-webview-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use StringPiece for CreateUploader/NetMetricsLogUploader params. Makes MetricsLogUploader a pure interface, eliminating the params there, and in TestMetricsLogUploader. TBR=boliu,olivierrobin BUG=693676 Review-Url: https://codereview.chromium.org/2735443003 Cr-Commit-Position: refs/heads/master@{#455308} Committed: https://chromium.googlesource.com/chromium/src/+/4ae63f527eab99ac2d363f6605ef699065d5e180

Patch Set 1 #

Total comments: 4

Patch Set 2 : Pass by value #

Patch Set 3 : Explicit constructor #

Patch Set 4 : Fix missed destruction #

Patch Set 5 : Fix destructor #

Total comments: 1

Patch Set 6 : Nit and Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -98 lines) Patch
M android_webview/native/aw_metrics_service_client_impl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_metrics_service_client_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/metrics/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/metrics/metrics_log_uploader.h View 1 2 3 4 5 2 chunks +2 lines, -22 lines 0 comments Download
D components/metrics/metrics_log_uploader.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M components/metrics/metrics_service_client.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/metrics/net/net_metrics_log_uploader.h View 1 3 chunks +15 lines, -6 lines 0 comments Download
M components/metrics/net/net_metrics_log_uploader.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M components/metrics/test_metrics_log_uploader.h View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M components/metrics/test_metrics_log_uploader.cc View 1 chunk +1 line, -8 lines 0 comments Download
M components/metrics/test_metrics_service_client.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/metrics/test_metrics_service_client.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/today_extension/today_metrics_logger.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 32 (19 generated)
Steven Holte
3 years, 9 months ago (2017-03-04 00:08:28 UTC) #2
Alexei Svitkine (slow)
https://codereview.chromium.org/2735443003/diff/1/android_webview/native/aw_metrics_service_client_impl.h File android_webview/native/aw_metrics_service_client_impl.h (right): https://codereview.chromium.org/2735443003/diff/1/android_webview/native/aw_metrics_service_client_impl.h#newcode57 android_webview/native/aw_metrics_service_client_impl.h:57: const base::StringPiece& server_url, StringPiece should be passed by value. ...
3 years, 9 months ago (2017-03-06 21:07:46 UTC) #3
Steven Holte
https://codereview.chromium.org/2735443003/diff/1/android_webview/native/aw_metrics_service_client_impl.h File android_webview/native/aw_metrics_service_client_impl.h (right): https://codereview.chromium.org/2735443003/diff/1/android_webview/native/aw_metrics_service_client_impl.h#newcode57 android_webview/native/aw_metrics_service_client_impl.h:57: const base::StringPiece& server_url, On 2017/03/06 21:07:46, Alexei Svitkine (very ...
3 years, 9 months ago (2017-03-06 21:22:11 UTC) #4
Alexei Svitkine (slow)
lgtm
3 years, 9 months ago (2017-03-06 21:26:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735443003/60001
3 years, 9 months ago (2017-03-07 01:53:22 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/322045) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-07 02:04:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735443003/80001
3 years, 9 months ago (2017-03-07 02:35:07 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/395401)
3 years, 9 months ago (2017-03-07 04:25:29 UTC) #21
Alexei Svitkine (slow)
https://codereview.chromium.org/2735443003/diff/80001/components/metrics/metrics_log_uploader.h File components/metrics/metrics_log_uploader.h (right): https://codereview.chromium.org/2735443003/diff/80001/components/metrics/metrics_log_uploader.h#newcode27 components/metrics/metrics_log_uploader.h:27: virtual ~MetricsLogUploader() {}; Nit: Remove ;
3 years, 9 months ago (2017-03-07 04:39:49 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735443003/100001
3 years, 9 months ago (2017-03-07 21:48:20 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/324303)
3 years, 9 months ago (2017-03-07 22:56:37 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735443003/100001
3 years, 9 months ago (2017-03-07 23:15:00 UTC) #29
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 00:25:51 UTC) #32
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/4ae63f527eab99ac2d363f6605ef...

Powered by Google App Engine
This is Rietveld 408576698