Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: components/metrics/net/net_metrics_log_uploader.cc

Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params. (Closed)
Patch Set: Nit and Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/net/net_metrics_log_uploader.h ('k') | components/metrics/test_metrics_log_uploader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/net/net_metrics_log_uploader.cc
diff --git a/components/metrics/net/net_metrics_log_uploader.cc b/components/metrics/net/net_metrics_log_uploader.cc
index 0064177a58c8991cec99004971d86c6df20d1231..ee1af76a6c9a63d3fc753aaf3856553f1f9199f8 100644
--- a/components/metrics/net/net_metrics_log_uploader.cc
+++ b/components/metrics/net/net_metrics_log_uploader.cc
@@ -15,15 +15,15 @@ namespace metrics {
NetMetricsLogUploader::NetMetricsLogUploader(
net::URLRequestContextGetter* request_context_getter,
- const std::string& server_url,
- const std::string& mime_type,
+ base::StringPiece server_url,
+ base::StringPiece mime_type,
MetricsLogUploader::MetricServiceType service_type,
const base::Callback<void(int)>& on_upload_complete)
- : MetricsLogUploader(server_url,
- mime_type,
- service_type,
- on_upload_complete),
- request_context_getter_(request_context_getter) {}
+ : request_context_getter_(request_context_getter),
+ server_url_(server_url),
+ mime_type_(mime_type.data(), mime_type.size()),
+ service_type_(service_type),
+ on_upload_complete_(on_upload_complete) {}
NetMetricsLogUploader::~NetMetricsLogUploader() {
}
« no previous file with comments | « components/metrics/net/net_metrics_log_uploader.h ('k') | components/metrics/test_metrics_log_uploader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698