chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params. (Closed)

Patch Set: Nit and Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index 9d4166f381f12f87ce197b2648fce94a57ea3bac..ba11cca2812c47811e253684ae59d0b31941ad08 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -513,8 +513,8 @@ void ChromeMetricsServiceClient::CollectFinalMetricsForLog(

std::unique_ptr<metrics::MetricsLogUploader>

ChromeMetricsServiceClient::CreateUploader(

- const std::string& server_url,

- const std::string& mime_type,

+ base::StringPiece server_url,

+ base::StringPiece mime_type,

metrics::MetricsLogUploader::MetricServiceType service_type,

const base::Callback<void(int)>& on_upload_complete) {

return std::unique_ptr<metrics::MetricsLogUploader>(