Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: ios/chrome/today_extension/today_metrics_logger.mm

Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params. (Closed)
Patch Set: Nit and Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/today_extension/today_metrics_logger.mm
diff --git a/ios/chrome/today_extension/today_metrics_logger.mm b/ios/chrome/today_extension/today_metrics_logger.mm
index 8022d431e17a80d7562de7719f8eda8da96677e8..8225f0ee05db0bb31dbab68ffbd18d0aaa5faeff 100644
--- a/ios/chrome/today_extension/today_metrics_logger.mm
+++ b/ios/chrome/today_extension/today_metrics_logger.mm
@@ -69,8 +69,8 @@ class TodayMetricsServiceClient : public metrics::MetricsServiceClient {
const base::Closure& done_callback) override;
void CollectFinalMetricsForLog(const base::Closure& done_callback) override;
std::unique_ptr<metrics::MetricsLogUploader> CreateUploader(
- const std::string& server_url,
- const std::string& mime_type,
+ base::StringPiece server_url,
+ base::StringPiece mime_type,
metrics::MetricsLogUploader::MetricServiceType service_type,
const base::Callback<void(int)>& on_upload_complete) override;
base::TimeDelta GetStandardUploadInterval() override;
@@ -150,8 +150,8 @@ void TodayMetricsServiceClient::CollectFinalMetricsForLog(
std::unique_ptr<metrics::MetricsLogUploader>
TodayMetricsServiceClient::CreateUploader(
- const std::string& server_url,
- const std::string& mime_type,
+ base::StringPiece server_url,
+ base::StringPiece mime_type,
metrics::MetricsLogUploader::MetricServiceType service_type,
const base::Callback<void(int)>& on_upload_complete) {
NOTREACHED();
« no previous file with comments | « ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698