Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7936)

Unified Diff: components/metrics/test_metrics_log_uploader.cc

Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params. (Closed)
Patch Set: Nit and Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/test_metrics_log_uploader.h ('k') | components/metrics/test_metrics_service_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/test_metrics_log_uploader.cc
diff --git a/components/metrics/test_metrics_log_uploader.cc b/components/metrics/test_metrics_log_uploader.cc
index 9c701cce963d7d9e1ff0d05b61c6c0e44ccaa3fc..be5942224c393e64aeabc216ac2c1a3d2106f7ec 100644
--- a/components/metrics/test_metrics_log_uploader.cc
+++ b/components/metrics/test_metrics_log_uploader.cc
@@ -8,15 +8,8 @@
namespace metrics {
TestMetricsLogUploader::TestMetricsLogUploader(
- const std::string& server_url,
- const std::string& mime_type,
- MetricsLogUploader::MetricServiceType service_type,
const base::Callback<void(int)>& on_upload_complete)
- : MetricsLogUploader(server_url,
- mime_type,
- service_type,
- on_upload_complete),
- is_uploading_(false) {}
+ : on_upload_complete_(on_upload_complete), is_uploading_(false) {}
TestMetricsLogUploader::~TestMetricsLogUploader() = default;
« no previous file with comments | « components/metrics/test_metrics_log_uploader.h ('k') | components/metrics/test_metrics_service_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698