chromecast/browser/metrics/cast_metrics_service_client.h - Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.h

Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params. (Closed)

Patch Set: Nit and Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/browser/metrics/cast_metrics_service_client.h

diff --git a/chromecast/browser/metrics/cast_metrics_service_client.h b/chromecast/browser/metrics/cast_metrics_service_client.h

index a45cee9c58b2e8fd05b3158234c8a25748cb4b58..aecc2a4f647ce656cd4c72ab87f4de2edec8fc60 100644

--- a/chromecast/browser/metrics/cast_metrics_service_client.h

+++ b/chromecast/browser/metrics/cast_metrics_service_client.h

@@ -80,8 +80,8 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient,

void CollectFinalMetricsForLog(const base::Closure& done_callback) override;

std::string GetMetricsServerUrl() override;

std::unique_ptr<::metrics::MetricsLogUploader> CreateUploader(

- const std::string& server_url,

- const std::string& mime_type,

+ base::StringPiece server_url,

+ base::StringPiece mime_type,

::metrics::MetricsLogUploader::MetricServiceType service_type,

const base::Callback<void(int)>& on_upload_complete) override;

base::TimeDelta GetStandardUploadInterval() override;