Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: components/metrics/test_metrics_log_uploader.h

Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params. (Closed)
Patch Set: Nit and Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/net/net_metrics_log_uploader.cc ('k') | components/metrics/test_metrics_log_uploader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/test_metrics_log_uploader.h
diff --git a/components/metrics/test_metrics_log_uploader.h b/components/metrics/test_metrics_log_uploader.h
index 196370a4198993e969d6b835647e316bab24c3c5..abc43cce0cdf19ca477b240d92c1677f7724b0e5 100644
--- a/components/metrics/test_metrics_log_uploader.h
+++ b/components/metrics/test_metrics_log_uploader.h
@@ -11,10 +11,8 @@ namespace metrics {
class TestMetricsLogUploader : public MetricsLogUploader {
public:
- TestMetricsLogUploader(const std::string& server_url,
- const std::string& mime_type,
- MetricsLogUploader::MetricServiceType service_type,
- const base::Callback<void(int)>& on_upload_complete);
+ explicit TestMetricsLogUploader(
+ const base::Callback<void(int)>& on_upload_complete);
~TestMetricsLogUploader() override;
// Mark the current upload complete with the given response code.
@@ -28,6 +26,7 @@ class TestMetricsLogUploader : public MetricsLogUploader {
void UploadLog(const std::string& compressed_log_data,
const std::string& log_hash) override;
+ const base::Callback<void(int)> on_upload_complete_;
bool is_uploading_;
DISALLOW_COPY_AND_ASSIGN(TestMetricsLogUploader);
« no previous file with comments | « components/metrics/net/net_metrics_log_uploader.cc ('k') | components/metrics/test_metrics_log_uploader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698