android_webview/native/aw_metrics_service_client_impl.cc - Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_metrics_service_client_impl.cc

Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params. (Closed)

Patch Set: Nit and Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_metrics_service_client_impl.cc

diff --git a/android_webview/native/aw_metrics_service_client_impl.cc b/android_webview/native/aw_metrics_service_client_impl.cc

index d1ab432a32e5bf369f02631273baf45fbe475704..2b0d7448671958d4b520c478b2e922aa26f8ee20 100644

--- a/android_webview/native/aw_metrics_service_client_impl.cc

+++ b/android_webview/native/aw_metrics_service_client_impl.cc

@@ -203,8 +203,8 @@ void AwMetricsServiceClientImpl::CollectFinalMetricsForLog(

std::unique_ptr<metrics::MetricsLogUploader>

AwMetricsServiceClientImpl::CreateUploader(

- const std::string& server_url,

- const std::string& mime_type,

+ base::StringPiece server_url,

+ base::StringPiece mime_type,

metrics::MetricsLogUploader::MetricServiceType service_type,

const base::Callback<void(int)>& on_upload_complete) {

return std::unique_ptr<::metrics::MetricsLogUploader>(