Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2730573003: Moved FrameHost::m_visualViewport to Page (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
slangley, haraken
CC:
apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, caseq+blink_chromium.org, chromium-reviews, dcheng, devtools-reviews_chromium.org, dglazkov+blink, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, jchaffraix+rendering, kenneth.christiansen, kinuko+watch, kozyatinskiy+blink_chromium.org, leviw+renderwatch, lushnikov+blink_chromium.org, mlamouri+watch-blink_chromium.org, Navid Zolghadr, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sof, Srirama, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved FrameHost::m_visualViewport to Page Moved FrameHost::m_visualViewport and it's methods to Page, and updated callers to use Page instead. This is part of merging FrameHost back into Page. BUG=691794 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2730573003 Cr-Commit-Position: refs/heads/master@{#456326} Committed: https://chromium.googlesource.com/chromium/src/+/4c516312b21a48df2839de5a1e5e5e338a1ed4de

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Fixed android compile error #

Patch Set 5 : Fixed some compile errors on mac and android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -263 lines) Patch
M third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ViewportDescription.cpp View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/BrowserControls.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.h View 1 2 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 2 4 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrameTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/ImageDocument.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/GestureManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMedia.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 2 1 chunk +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 2 5 chunks +14 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyPageHolder.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/PageOverlay.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetBase.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 23 chunks +27 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/web/mac/WebSubstringUtil.mm View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/RootScrollerTest.cpp View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TextFinderTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 2 37 chunks +38 lines, -76 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 5 chunks +8 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 33 (25 generated)
sashab
Got greedy and tried to do 2 things in one patch :P Let's see if ...
3 years, 9 months ago (2017-03-02 05:09:00 UTC) #5
haraken
LGTM
3 years, 9 months ago (2017-03-02 05:23:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730573003/40001
3 years, 9 months ago (2017-03-13 03:17:43 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/248740)
3 years, 9 months ago (2017-03-13 03:26:38 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730573003/60001
3 years, 9 months ago (2017-03-13 03:52:30 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/405289)
3 years, 9 months ago (2017-03-13 04:00:05 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730573003/80001
3 years, 9 months ago (2017-03-13 04:04:56 UTC) #30
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 05:34:39 UTC) #33
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4c516312b21a48df2839de5a1e5e...

Powered by Google App Engine
This is Rietveld 408576698