third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp - Issue 2730573003: Moved FrameHost::m_visualViewport to Page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2730573003: Moved FrameHost::m_visualViewport to Page (Closed)

Patch Set: Fixed some compile errors on mac and android Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/Page.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

index e0a0d72d5c18bff5f7e2d48a59ad9c489de250d7..aff5a7e32eb2a4fad4eb8a2269433fe933ad360c 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

@@ -235,7 +235,7 @@ void ScrollingCoordinator::updateAfterCompositingChangeIfNeeded() {

Element* fullscreenElement =

Fullscreen::fullscreenElementFrom(*mainFrameDocument);

WebLayer* visualViewportScrollLayer =

- toWebLayer(m_page->frameHost().visualViewport().scrollLayer());

+ toWebLayer(m_page->visualViewport().scrollLayer());

if (visualViewportScrollLayer) {

if (fullscreenElement &&

@@ -485,8 +485,7 @@ bool ScrollingCoordinator::scrollableAreaScrollLayerDidChange(

GraphicsLayer* scrollLayer = scrollableArea->layerForScrolling();

if (scrollLayer) {

- bool isForVisualViewport =

- scrollableArea == &m_page->frameHost().visualViewport();

+ bool isForVisualViewport = scrollableArea == &m_page->visualViewport();

scrollLayer->setScrollableArea(scrollableArea, isForVisualViewport);

}

@@ -840,8 +839,7 @@ void ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread(

!m_page->deprecatedLocalMainFrame()->view())

return;

- GraphicsLayer* visualViewportLayer =

- m_page->frameHost().visualViewport().scrollLayer();

+ GraphicsLayer* visualViewportLayer = m_page->visualViewport().scrollLayer();

WebLayer* visualViewportScrollLayer = toWebLayer(visualViewportLayer);

GraphicsLayer* layer = m_page->deprecatedLocalMainFrame()

->view()