third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp - Issue 2730573003: Moved FrameHost::m_visualViewport to Page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

Issue 2730573003: Moved FrameHost::m_visualViewport to Page (Closed)

Patch Set: Fixed some compile errors on mac and android Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp ('k') | third_party/WebKit/Source/core/testing/DummyPageHolder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp b/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

index 6ec136ea70cb2bf0599489abf2e11cdc9b08e8bf..bafdeb04ba7cee30f1d2541fbe3056f14b63cb61 100644

--- a/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

@@ -71,9 +71,8 @@ IntSize TopDocumentRootScrollerController::rootScrollerVisibleArea() const {

float minimumPageScale =

m_page->pageScaleConstraintsSet().finalConstraints().minimumScale;

- int browserControlsAdjustment =

- ceilf(m_page->frameHost().visualViewport().browserControlsAdjustment() /

- minimumPageScale);

+ int browserControlsAdjustment = ceilf(

+ m_page->visualViewport().browserControlsAdjustment() / minimumPageScale);

return topDocument()->view()->visibleContentSize(ExcludeScrollbars) +

IntSize(0, browserControlsAdjustment);