Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutMedia.cpp

Issue 2730573003: Moved FrameHost::m_visualViewport to Page (Closed)
Patch Set: Fixed some compile errors on mac and android Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "core/layout/LayoutMedia.h" 26 #include "core/layout/LayoutMedia.h"
27 27
28 #include "core/frame/FrameHost.h"
29 #include "core/frame/FrameView.h" 28 #include "core/frame/FrameView.h"
30 #include "core/frame/VisualViewport.h" 29 #include "core/frame/VisualViewport.h"
31 #include "core/html/HTMLMediaElement.h" 30 #include "core/html/HTMLMediaElement.h"
32 #include "core/html/shadow/MediaControls.h" 31 #include "core/html/shadow/MediaControls.h"
33 #include "core/layout/LayoutView.h" 32 #include "core/layout/LayoutView.h"
34 #include "core/page/Page.h" 33 #include "core/page/Page.h"
35 34
36 namespace blink { 35 namespace blink {
37 36
38 LayoutMedia::LayoutMedia(HTMLMediaElement* video) : LayoutImage(video) { 37 LayoutMedia::LayoutMedia(HTMLMediaElement* video) : LayoutImage(video) {
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 // if it is out of process. See https://crbug.com/662480 143 // if it is out of process. See https://crbug.com/662480
145 if (document().page()->mainFrame()->isRemoteFrame()) 144 if (document().page()->mainFrame()->isRemoteFrame())
146 return mediaRect.width(); 145 return mediaRect.width();
147 146
148 // TODO(foolip): when going fullscreen, the animation sometimes does not clear 147 // TODO(foolip): when going fullscreen, the animation sometimes does not clear
149 // up properly and the last `absoluteXOffset` received is incorrect. This is 148 // up properly and the last `absoluteXOffset` received is incorrect. This is
150 // a shortcut that we could ideally avoid. See https://crbug.com/663680 149 // a shortcut that we could ideally avoid. See https://crbug.com/663680
151 if (mediaElement() && mediaElement()->isFullscreen()) 150 if (mediaElement() && mediaElement()->isFullscreen())
152 return mediaRect.width(); 151 return mediaRect.width();
153 152
154 FrameHost* frameHost = document().frameHost(); 153 Page* page = document().page();
155 LocalFrame* mainFrame = document().page()->deprecatedLocalMainFrame(); 154 LocalFrame* mainFrame = page->deprecatedLocalMainFrame();
156 FrameView* pageView = mainFrame ? mainFrame->view() : nullptr; 155 FrameView* pageView = mainFrame ? mainFrame->view() : nullptr;
157 if (!frameHost || !mainFrame || !pageView) 156 if (!mainFrame || !pageView)
158 return mediaRect.width(); 157 return mediaRect.width();
159 158
160 if (pageView->horizontalScrollbarMode() != ScrollbarAlwaysOff) 159 if (pageView->horizontalScrollbarMode() != ScrollbarAlwaysOff)
161 return mediaRect.width(); 160 return mediaRect.width();
162 161
163 // On desktop, this will include scrollbars when they stay visible. 162 // On desktop, this will include scrollbars when they stay visible.
164 const LayoutUnit visibleWidth(frameHost->visualViewport().visibleWidth()); 163 const LayoutUnit visibleWidth(page->visualViewport().visibleWidth());
165 const LayoutUnit absoluteXOffset( 164 const LayoutUnit absoluteXOffset(
166 localToAbsolute( 165 localToAbsolute(
167 FloatPoint(mediaRect.location()), 166 FloatPoint(mediaRect.location()),
168 UseTransforms | ApplyContainerFlip | TraverseDocumentBoundaries) 167 UseTransforms | ApplyContainerFlip | TraverseDocumentBoundaries)
169 .x()); 168 .x());
170 const LayoutUnit newWidth = visibleWidth - absoluteXOffset; 169 const LayoutUnit newWidth = visibleWidth - absoluteXOffset;
171 170
172 if (newWidth < 0) 171 if (newWidth < 0)
173 return mediaRect.width(); 172 return mediaRect.width();
174 173
175 return std::min(mediaRect.width(), visibleWidth - absoluteXOffset); 174 return std::min(mediaRect.width(), visibleWidth - absoluteXOffset);
176 } 175 }
177 176
178 } // namespace blink 177 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp ('k') | third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698