Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/web/DevToolsEmulator.cpp

Issue 2730573003: Moved FrameHost::m_visualViewport to Page (Closed)
Patch Set: Fixed some compile errors on mac and android Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/DevToolsEmulator.cpp
diff --git a/third_party/WebKit/Source/web/DevToolsEmulator.cpp b/third_party/WebKit/Source/web/DevToolsEmulator.cpp
index 8caa5b1002b61e3fabf813590f2eeeabacd214f8..b3c9f0540c9aea97bf0e827c19da4e5f7fde0fb1 100644
--- a/third_party/WebKit/Source/web/DevToolsEmulator.cpp
+++ b/third_party/WebKit/Source/web/DevToolsEmulator.cpp
@@ -277,7 +277,7 @@ void DevToolsEmulator::enableMobileEmulation() {
m_webViewImpl->page()->settings().setViewportStyle(WebViewportStyle::Mobile);
m_webViewImpl->page()->settings().setViewportEnabled(true);
m_webViewImpl->page()->settings().setViewportMetaEnabled(true);
- m_webViewImpl->page()->frameHost().visualViewport().initializeScrollbars();
+ m_webViewImpl->page()->visualViewport().initializeScrollbars();
m_webViewImpl->settings()->setShrinksViewportContentToFit(true);
m_webViewImpl->page()->settings().setTextAutosizingEnabled(true);
m_webViewImpl->page()->settings().setPreferCompositingToLCDTextEnabled(true);
@@ -313,7 +313,7 @@ void DevToolsEmulator::disableMobileEmulation() {
ComputedStyle::invalidateInitialStyle();
m_webViewImpl->page()->settings().setViewportEnabled(false);
m_webViewImpl->page()->settings().setViewportMetaEnabled(false);
- m_webViewImpl->page()->frameHost().visualViewport().initializeScrollbars();
+ m_webViewImpl->page()->visualViewport().initializeScrollbars();
m_webViewImpl->settings()->setShrinksViewportContentToFit(false);
m_webViewImpl->page()->settings().setTextAutosizingEnabled(
m_embedderTextAutosizingEnabled);
@@ -350,7 +350,7 @@ float DevToolsEmulator::compositorDeviceScaleFactor() const {
void DevToolsEmulator::forceViewport(const WebFloatPoint& position,
float scale) {
GraphicsLayer* containerLayer =
- m_webViewImpl->page()->frameHost().visualViewport().containerLayer();
+ m_webViewImpl->page()->visualViewport().containerLayer();
if (!m_viewportOverride) {
m_viewportOverride = ViewportOverride();
@@ -379,7 +379,7 @@ void DevToolsEmulator::resetViewport() {
m_viewportOverride = WTF::nullopt;
GraphicsLayer* containerLayer =
- m_webViewImpl->page()->frameHost().visualViewport().containerLayer();
+ m_webViewImpl->page()->visualViewport().containerLayer();
if (containerLayer)
containerLayer->setMasksToBounds(originalMasking);
updateRootLayerTransform();
« no previous file with comments | « third_party/WebKit/Source/core/testing/Internals.cpp ('k') | third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698