Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp

Issue 2730573003: Moved FrameHost::m_visualViewport to Page (Closed)
Patch Set: Fixed some compile errors on mac and android Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp
diff --git a/third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp b/third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp
index 98864784a2ea088d04d223f5b1e12e2bf9934806..e3d5c8f1e843df16cb14cb279141b93b653257a8 100644
--- a/third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp
+++ b/third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp
@@ -60,8 +60,8 @@ float DOMVisualViewport::scrollLeft() {
if (!frame || !frame->isMainFrame())
return 0;
- if (FrameHost* host = frame->host())
- return host->visualViewport().scrollLeft();
+ if (Page* page = frame->page())
+ return page->visualViewport().scrollLeft();
return 0;
}
@@ -71,8 +71,8 @@ float DOMVisualViewport::scrollTop() {
if (!frame || !frame->isMainFrame())
return 0;
- if (FrameHost* host = frame->host())
- return host->visualViewport().scrollTop();
+ if (Page* page = frame->page())
+ return page->visualViewport().scrollTop();
return 0;
}
@@ -116,8 +116,8 @@ double DOMVisualViewport::clientWidth() {
frame->pageZoomFactor());
}
- if (FrameHost* host = frame->host())
- return host->visualViewport().clientWidth();
+ if (Page* page = frame->page())
+ return page->visualViewport().clientWidth();
return 0;
}
@@ -133,8 +133,8 @@ double DOMVisualViewport::clientHeight() {
frame->pageZoomFactor());
}
- if (FrameHost* host = frame->host())
- return host->visualViewport().clientHeight();
+ if (Page* page = frame->page())
+ return page->visualViewport().clientHeight();
return 0;
}
@@ -147,8 +147,8 @@ double DOMVisualViewport::scale() {
if (!frame->isMainFrame())
return 1;
- if (FrameHost* host = m_window->frame()->host())
- return host->visualViewport().pageScale();
+ if (Page* page = m_window->frame()->page())
+ return page->visualViewport().pageScale();
return 0;
}
« no previous file with comments | « third_party/WebKit/Source/core/frame/BrowserControls.cpp ('k') | third_party/WebKit/Source/core/frame/FrameHost.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698