third_party/WebKit/Source/core/dom/Element.cpp - Issue 2730573003: Moved FrameHost::m_visualViewport to Page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2730573003: Moved FrameHost::m_visualViewport to Page (Closed)

Patch Set: Fixed some compile errors on mac and android Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index caaf1fe05d10ca5267b2d3a3c44abf3a76a5d246..7439353a56279060a8e375590fb95951490fd885 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -1115,7 +1115,7 @@ IntRect Element::visibleBoundsInVisualViewport() const {

return IntRect();

// TODO(tkent): Can we check invisibility by scrollable non-frame elements?

- IntSize viewportSize = document().page()->frameHost().visualViewport().size();

+ IntSize viewportSize = document().page()->visualViewport().size();

IntRect rect(0, 0, viewportSize.width(), viewportSize.height());

// We don't use absoluteBoundingBoxRect() because it can return an IntRect

// larger the actual size by 1px. crbug.com/470503